----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101788/ -----------------------------------------------------------
(Updated June 27, 2011, 9:41 p.m.) Review request for Network Management. Changes ------- added comment. Summary ------- Add an OpenConnect VPN plug-in to KDE NM. First time using threads, so I don't know if that's how it's supposed to be done, but it seems to be working. Also, I can't figure out how to make the loginForm QGroupBox have a minimum height, but get bigger when widgets get added. If the minimum height is 0, then both the box and the dialog get resized, however this causes visual "interference" as the serverLogBox jumps up and down as the upper loginForm box gets resized. Setting the minimum height of the loginForm box to 100 causes it to stay at 100 and squeeze the added widgets to fit the size, instead of getting bigger. Any ideas? This requires OpenConnect >= 3.03 to build. 3.03 is not yet released, but the important thing is commit 423eee0b51a204562d6f2ec67893133ebcf200d6 from OpenConnect git (http://git.infradead.org/users/dwmw2/openconnect.git/ ) This addresses bug 226028. http://bugs.kde.org/show_bug.cgi?id=226028 Diffs (updated) ----- libs/internals/settings/vpnsecrets.cpp 0d9e3f9 libs/ui/connectionsecretsjob.cpp d791bb3 libs/ui/vpnuiplugin.h 444ab2a libs/ui/vpnuiplugin.cpp d058a52 vpnplugins/CMakeLists.txt 4706a61 vpnplugins/openconnect/CMakeLists.txt PRE-CREATION vpnplugins/openconnect/FindOpenConnect.cmake PRE-CREATION vpnplugins/openconnect/README PRE-CREATION vpnplugins/openconnect/networkmanagement_openconnectui.desktop PRE-CREATION vpnplugins/openconnect/nm-openconnect-service.h PRE-CREATION vpnplugins/openconnect/openconnectauth.h PRE-CREATION vpnplugins/openconnect/openconnectauth.cpp PRE-CREATION vpnplugins/openconnect/openconnectauth.ui PRE-CREATION vpnplugins/openconnect/openconnectauthworkerthread.h PRE-CREATION vpnplugins/openconnect/openconnectauthworkerthread.cpp PRE-CREATION vpnplugins/openconnect/openconnectprop.ui PRE-CREATION vpnplugins/openconnect/openconnectui.h PRE-CREATION vpnplugins/openconnect/openconnectui.cpp PRE-CREATION vpnplugins/openconnect/openconnectwidget.h PRE-CREATION vpnplugins/openconnect/openconnectwidget.cpp PRE-CREATION Diff: http://git.reviewboard.kde.org/r/101788/diff Testing ------- Yes, see the bugzilla ticket. Screenshots ----------- http://git.reviewboard.kde.org/r/101788/s/191/ Thanks, Ilia
_______________________________________________ kde-networkmanager mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-networkmanager
