> On June 27, 2011, 12:37 p.m., Lamarque Vieira Souza wrote: > > vpnplugins/openconnect/openconnectwidget.cpp, line 50 > > <http://git.reviewboard.kde.org/r/101788/diff/1/?file=25396#file25396line50> > > > > Do not do this. This class inherit from SettingWidget, which has a > > virtual destructor, which already deletes d_ptr. You are doing a double > > delete here, which will corrupt system memory. Just remove this line. > > Ilia Kats wrote: > As far as I know, this would only apply if OpenconnectAuthWidgetPrivate > would inherit from SettingWidgetPrivate, which it does not. All the other VPN > plugins are also deleting their d-pointers. > > Ilia Kats wrote: > OpenconnectSettingWidgetPrivate, sorry. Applies for the auth widget too, > though. > > Lamarque Vieira Souza wrote: > So they are all double deleting. SettingWidget's destructor is virtual, > if it was not then there would be no problem. Besides, SettingWidgetPrivate > does not even have a destructor.
Ok, I checked this and there is no double deleting because the classes that inherit from SettingWidget also declare d_ptr by theirselves. The d_ptr in them is not the same one in SettingWidget, so we really need to delete them all. - Lamarque Vieira ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101788/#review4198 ----------------------------------------------------------- On June 27, 2011, 10:07 p.m., Ilia Kats wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/101788/ > ----------------------------------------------------------- > > (Updated June 27, 2011, 10:07 p.m.) > > > Review request for Network Management. > > > Summary > ------- > > Add an OpenConnect VPN plug-in to KDE NM. First time using threads, so I > don't know if that's how it's supposed to be done, but it seems to be working. > Also, I can't figure out how to make the loginForm QGroupBox have a minimum > height, but get bigger when widgets get added. If the minimum height is 0, > then both the box and the dialog get resized, however this causes visual > "interference" as the serverLogBox jumps up and down as the upper loginForm > box gets resized. Setting the minimum height of the loginForm box to 100 > causes it to stay at 100 and squeeze the added widgets to fit the size, > instead of getting bigger. Any ideas? > > This requires OpenConnect >= 3.03 to build. 3.03 is not yet released, but the > important thing is commit 423eee0b51a204562d6f2ec67893133ebcf200d6 from > OpenConnect git (http://git.infradead.org/users/dwmw2/openconnect.git/ ) > > > This addresses bug 226028. > http://bugs.kde.org/show_bug.cgi?id=226028 > > > Diffs > ----- > > libs/internals/settings/vpnsecrets.cpp 0d9e3f9 > libs/ui/connectionsecretsjob.cpp d791bb3 > libs/ui/vpnuiplugin.h 444ab2a > libs/ui/vpnuiplugin.cpp d058a52 > vpnplugins/CMakeLists.txt 4706a61 > vpnplugins/openconnect/CMakeLists.txt PRE-CREATION > vpnplugins/openconnect/FindOpenConnect.cmake PRE-CREATION > vpnplugins/openconnect/README PRE-CREATION > vpnplugins/openconnect/networkmanagement_openconnectui.desktop PRE-CREATION > vpnplugins/openconnect/nm-openconnect-service.h PRE-CREATION > vpnplugins/openconnect/openconnectauth.h PRE-CREATION > vpnplugins/openconnect/openconnectauth.cpp PRE-CREATION > vpnplugins/openconnect/openconnectauth.ui PRE-CREATION > vpnplugins/openconnect/openconnectauthworkerthread.h PRE-CREATION > vpnplugins/openconnect/openconnectauthworkerthread.cpp PRE-CREATION > vpnplugins/openconnect/openconnectprop.ui PRE-CREATION > vpnplugins/openconnect/openconnectui.h PRE-CREATION > vpnplugins/openconnect/openconnectui.cpp PRE-CREATION > vpnplugins/openconnect/openconnectwidget.h PRE-CREATION > vpnplugins/openconnect/openconnectwidget.cpp PRE-CREATION > > Diff: http://git.reviewboard.kde.org/r/101788/diff > > > Testing > ------- > > Yes, see the bugzilla ticket. > > > Screenshots > ----------- > > > http://git.reviewboard.kde.org/r/101788/s/191/ > > > Thanks, > > Ilia > >
_______________________________________________ kde-networkmanager mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-networkmanager
