> On July 23, 2011, 5:26 p.m., Ilia Kats wrote: > > settings/config/manageconnectionwidget.cpp, line 405 > > <http://git.reviewboard.kde.org/r/102059/diff/1/?file=29549#file29549line405> > > > > At this point, it would probably be best to let the plugins specify the > > file extensions. The method could return a QStringList, which > > ManageConnectionWidget would collect from all installed plugins, then join > > them to a QString and call KFileDialog. > > Rajeesh K Nambiar wrote: > Possibly another method into VpnUiPlugin?
That's what I thought. > On July 23, 2011, 5:26 p.m., Ilia Kats wrote: > > vpnplugins/openvpn/openvpn.cpp, line 204 > > <http://git.reviewboard.kde.org/r/102059/diff/1/?file=29553#file29553line204> > > > > You're using these a lot here, without actually checking the return > > value, so regardless of what the user clicked, the import will continue. I > > think you'd need to introduce a new error type, like UserCanceled, and > > return an empty QVariantList after setting mError to this if Cancel was > > clicked (also, ManageConnectionWidget should recognize this error type and > > not display any additional pop-ups). > > Rajeesh K Nambiar wrote: > These are actually non-fatal messages, could be safely ignored. Is there > a better way than warningContinueCancel? How about KMessageBox::information? - Ilia ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102059/#review5005 ----------------------------------------------------------- On July 23, 2011, 4:41 p.m., Rajeesh K Nambiar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/102059/ > ----------------------------------------------------------- > > (Updated July 23, 2011, 4:41 p.m.) > > > Review request for Network Management. > > > Summary > ------- > > Caveat emptor: There is one unresolved issue with isEncrypted() function - we > need to check of key file is PKCS12 format or not. nm-applet achieves this > through a call to nm_setting_802_1x_set_private_key(). I've googled a lot, > and looks like there is no way to check PKCS12 file format in either Qt or > KDE. > If we are to add ad-hoc support via SEC_PKCS12DecoderStart and related > functions from nss (which is what NetworkManager does), it wil introduce a > new dependency on nss-devel. > > > This addresses bug 194099. > http://bugs.kde.org/show_bug.cgi?id=194099 > > > Diffs > ----- > > libs/ui/vpnuiplugin.h 932d86f > settings/config/manageconnectionwidget.cpp 780d50f > vpnplugins/novellvpn/novellvpn.h a95926b > vpnplugins/novellvpn/novellvpn.cpp 61d5519 > vpnplugins/openvpn/openvpn.h 4607cd5 > vpnplugins/openvpn/openvpn.cpp 6f126b8 > vpnplugins/pptp/pptp.h e513d3c > vpnplugins/pptp/pptp.cpp e4efbd7 > vpnplugins/strongswan/strongswan.h d648217 > vpnplugins/strongswan/strongswan.cpp 9d4a8be > vpnplugins/vpnc/vpnc.h 0b3f6db > vpnplugins/vpnc/vpnc.cpp ea24cf1 > > Diff: http://git.reviewboard.kde.org/r/102059/diff > > > Testing > ------- > > Only lightly tested, seems to import/export OK for sample configuration file. > I don't have an OpenVPN connection, so it would be great if someone could > test. > > > Thanks, > > Rajeesh > >
_______________________________________________ kde-networkmanager mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-networkmanager
