----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102059/#review5033 -----------------------------------------------------------
libs/ui/vpnuiplugin.h <http://git.reviewboard.kde.org/r/102059/#comment4465> Please add a comment like: "Suggested file name to save the exported connection configuration. Try not to use space, parenthesis, or any other Unix unfriendly file name character." libs/ui/vpnuiplugin.h <http://git.reviewboard.kde.org/r/102059/#comment4464> Add a comment like this: "File extention to be used in KFileDialog when selecting the file to import. The format is: *.<extension> [*.<extension> ...]. For instance: '*.pcf'" This is usefull for anybody who wants to implement import/export code for the remaining plugins. settings/config/manageconnectionwidget.h <http://git.reviewboard.kde.org/r/102059/#comment4463> "This variable will contain all file extensions supported by the import implementation of all VPN plugins. The extentions are separated by space, e.g '*.pcf *.ovpn' and are used in KFileDialog when selecting the file to import" settings/config/manageconnectionwidget.cpp <http://git.reviewboard.kde.org/r/102059/#comment4466> I think this is not necessary since you already implemented this for two plugins. Only if there is an error mSupportedExtns will be empty. vpnplugins/openvpn/openvpn.cpp <http://git.reviewboard.kde.org/r/102059/#comment4461> Well, I meant i18n("File %1 is not a valid OpenVPN's client configuration file", fileName) vpnplugins/openvpn/openvpn.cpp <http://git.reviewboard.kde.org/r/102059/#comment4462> same here. - Lamarque Vieira On July 24, 2011, 2:42 p.m., Rajeesh K Nambiar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/102059/ > ----------------------------------------------------------- > > (Updated July 24, 2011, 2:42 p.m.) > > > Review request for Network Management. > > > Summary > ------- > > Caveat emptor: There is one unresolved issue with isEncrypted() function - we > need to check of key file is PKCS12 format or not. nm-applet achieves this > through a call to nm_setting_802_1x_set_private_key(). I've googled a lot, > and looks like there is no way to check PKCS12 file format in either Qt or > KDE. > If we are to add ad-hoc support via SEC_PKCS12DecoderStart and related > functions from nss (which is what NetworkManager does), it wil introduce a > new dependency on nss-devel. > > > This addresses bug 194099. > http://bugs.kde.org/show_bug.cgi?id=194099 > > > Diffs > ----- > > libs/ui/vpnuiplugin.h 932d86f > settings/config/manageconnectionwidget.h 8f7a205 > settings/config/manageconnectionwidget.cpp 780d50f > vpnplugins/novellvpn/novellvpn.h a95926b > vpnplugins/novellvpn/novellvpn.cpp 61d5519 > vpnplugins/openconnect/openconnectui.h 8098aec > vpnplugins/openconnect/openconnectui.cpp 4d43afd > vpnplugins/openvpn/openvpn.h 4607cd5 > vpnplugins/openvpn/openvpn.cpp 6f126b8 > vpnplugins/pptp/pptp.h e513d3c > vpnplugins/pptp/pptp.cpp e4efbd7 > vpnplugins/strongswan/strongswan.h d648217 > vpnplugins/strongswan/strongswan.cpp 9d4a8be > vpnplugins/vpnc/vpnc.h 0b3f6db > vpnplugins/vpnc/vpnc.cpp ea24cf1 > > Diff: http://git.reviewboard.kde.org/r/102059/diff > > > Testing > ------- > > Only lightly tested, seems to import/export OK for sample configuration file. > I don't have an OpenVPN connection, so it would be great if someone could > test. > > > Thanks, > > Rajeesh > >
_______________________________________________ kde-networkmanager mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-networkmanager
