----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102059/#review5004 -----------------------------------------------------------
vpnplugins/openvpn/openvpn.cpp <http://git.reviewboard.kde.org/r/102059/#comment4439> There is no problem in adding nss-devel as dependency. Nss is also used by NetworkManager, so it is already installed. We just need to change the main CMakeLists.txt to look for it and disable openvpn importing/exporting if it is not installed and emmit a warning when that happen. vpnplugins/openvpn/openvpn.cpp <http://git.reviewboard.kde.org/r/102059/#comment4417> Using spaces and parenthesis in files names in Unix-like systems is no good. Change then to underscore instead: _. vpnplugins/openvpn/openvpn.cpp <http://git.reviewboard.kde.org/r/102059/#comment4434> You should not try to import a file whose extension is not supported (.ovpn and *.conf this this case). Windows does not support file extensions with more than three characters, do you know what is the extension they use? vpnplugins/openvpn/openvpn.cpp <http://git.reviewboard.kde.org/r/102059/#comment4419> Extend this warning message by adding the number of arguments found and the expected number (or range). vpnplugins/openvpn/openvpn.cpp <http://git.reviewboard.kde.org/r/102059/#comment4418> Extend this warning message by adding the number of arguments found and the expected number (or range). vpnplugins/openvpn/openvpn.cpp <http://git.reviewboard.kde.org/r/102059/#comment4420> Extend this warning message by adding the size found and the expected size. vpnplugins/openvpn/openvpn.cpp <http://git.reviewboard.kde.org/r/102059/#comment4421> Extend this warning message by adding the number of arguments found and the expected number (or range). vpnplugins/openvpn/openvpn.cpp <http://git.reviewboard.kde.org/r/102059/#comment4422> Extend this warning message by adding the size found and the expected size. vpnplugins/openvpn/openvpn.cpp <http://git.reviewboard.kde.org/r/102059/#comment4423> Extend this warning message by adding the number of arguments found and the expected number (or range). vpnplugins/openvpn/openvpn.cpp <http://git.reviewboard.kde.org/r/102059/#comment4424> Extend this warning message by adding the size found and the expected size. vpnplugins/openvpn/openvpn.cpp <http://git.reviewboard.kde.org/r/102059/#comment4425> Extend this warning message by adding the number of arguments found and the expected number (or range). vpnplugins/openvpn/openvpn.cpp <http://git.reviewboard.kde.org/r/102059/#comment4426> Extend this warning message by adding the number of arguments found and the expected number (or range). vpnplugins/openvpn/openvpn.cpp <http://git.reviewboard.kde.org/r/102059/#comment4435> Extend this warning message by adding the number of arguments found and the expected number (or range). vpnplugins/openvpn/openvpn.cpp <http://git.reviewboard.kde.org/r/102059/#comment4436> Extend this warning message by adding the number of arguments found and the expected number (or range). vpnplugins/openvpn/openvpn.cpp <http://git.reviewboard.kde.org/r/102059/#comment4437> Better not use contraction ("wasn't") in formal text. I think we can change this text to "File %1 is not a valid OpenVPN's client configuration file". vpnplugins/openvpn/openvpn.cpp <http://git.reviewboard.kde.org/r/102059/#comment4438> "File %1 is not a valid OpenVPN configuration file (no remote)" - Lamarque Vieira On July 23, 2011, 4:41 p.m., Rajeesh K Nambiar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/102059/ > ----------------------------------------------------------- > > (Updated July 23, 2011, 4:41 p.m.) > > > Review request for Network Management. > > > Summary > ------- > > Caveat emptor: There is one unresolved issue with isEncrypted() function - we > need to check of key file is PKCS12 format or not. nm-applet achieves this > through a call to nm_setting_802_1x_set_private_key(). I've googled a lot, > and looks like there is no way to check PKCS12 file format in either Qt or > KDE. > If we are to add ad-hoc support via SEC_PKCS12DecoderStart and related > functions from nss (which is what NetworkManager does), it wil introduce a > new dependency on nss-devel. > > > This addresses bug 194099. > http://bugs.kde.org/show_bug.cgi?id=194099 > > > Diffs > ----- > > libs/ui/vpnuiplugin.h 932d86f > settings/config/manageconnectionwidget.cpp 780d50f > vpnplugins/novellvpn/novellvpn.h a95926b > vpnplugins/novellvpn/novellvpn.cpp 61d5519 > vpnplugins/openvpn/openvpn.h 4607cd5 > vpnplugins/openvpn/openvpn.cpp 6f126b8 > vpnplugins/pptp/pptp.h e513d3c > vpnplugins/pptp/pptp.cpp e4efbd7 > vpnplugins/strongswan/strongswan.h d648217 > vpnplugins/strongswan/strongswan.cpp 9d4a8be > vpnplugins/vpnc/vpnc.h 0b3f6db > vpnplugins/vpnc/vpnc.cpp ea24cf1 > > Diff: http://git.reviewboard.kde.org/r/102059/diff > > > Testing > ------- > > Only lightly tested, seems to import/export OK for sample configuration file. > I don't have an OpenVPN connection, so it would be great if someone could > test. > > > Thanks, > > Rajeesh > >
_______________________________________________ kde-networkmanager mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-networkmanager
