----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106961/#review20828 -----------------------------------------------------------
applet/interfacedetailswidget.cpp <http://git.reviewboard.kde.org/r/106961/#comment16441> You can save this value in a temporary variable and use it in the line below instead of calculating it twice. applet/nmpopup.cpp <http://git.reviewboard.kde.org/r/106961/#comment16442> same here. Actually you already calculated this value some lines above, you can reuse it instead of calculating it again. applet/nmpopup.cpp <http://git.reviewboard.kde.org/r/106961/#comment16443> here too. - Lamarque Vieira Souza On Oct. 21, 2012, 12:09 p.m., Michael Zanetti wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/106961/ > ----------------------------------------------------------- > > (Updated Oct. 21, 2012, 12:09 p.m.) > > > Review request for Network Management. > > > Description > ------- > > Some more fixes for Retina screen. Because the font scales with the DPI it > doesn't fit any more on the hardcoded button sizes. Here are example > screenshots: > > http://notyetthere.org/data/kde/nm-fixed-sizes.png > http://notyetthere.org/data/kde/nm-dynamic-sizes.png > > > Diffs > ----- > > applet/activatableitem.cpp 1198fd2 > applet/interfacedetailswidget.cpp 9635559 > applet/interfaceitem.cpp 356c285 > applet/nmpopup.cpp a8dfd54 > applet/wirelessinterfaceitem.cpp 8f71b20 > applet/wirelessnetworkitem.cpp 6489f5d > > Diff: http://git.reviewboard.kde.org/r/106961/diff/ > > > Testing > ------- > > > Thanks, > > Michael Zanetti > >
_______________________________________________ kde-networkmanager mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-networkmanager
