> On Nov. 3, 2012, 9:56 p.m., Lamarque Vieira Souza wrote: > > applet/nmpopup.cpp, line 186 > > <http://git.reviewboard.kde.org/r/106961/diff/3/?file=93433#file93433line186> > > > > remove trailing white-space. After that ship it.
Hmmm when I merge branch arthur to master (the QML version of the plasmoid) this code will no longer be used. Maybe you can try implementing this change in arthur branch too if you have time. I do not have any retina-like device here to test this. - Lamarque Vieira ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106961/#review21393 ----------------------------------------------------------- On Nov. 3, 2012, 9:31 p.m., Michael Zanetti wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/106961/ > ----------------------------------------------------------- > > (Updated Nov. 3, 2012, 9:31 p.m.) > > > Review request for Network Management. > > > Description > ------- > > Some more fixes for Retina screen. Because the font scales with the DPI it > doesn't fit any more on the hardcoded button sizes. Here are example > screenshots: > > http://notyetthere.org/data/kde/nm-fixed-sizes.png > http://notyetthere.org/data/kde/nm-dynamic-sizes.png > > > Diffs > ----- > > applet/activatableitem.cpp 1198fd2 > applet/interfacedetailswidget.cpp 9635559 > applet/interfaceitem.cpp 356c285 > applet/nmpopup.cpp a8dfd54 > applet/wirelessinterfaceitem.cpp 8f71b20 > applet/wirelessnetworkitem.cpp 6489f5d > > Diff: http://git.reviewboard.kde.org/r/106961/diff/ > > > Testing > ------- > > > Thanks, > > Michael Zanetti > >
_______________________________________________ kde-networkmanager mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-networkmanager
