----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122012/#review73845 -----------------------------------------------------------
vpn/openconnect/openconnectauth.cpp <https://git.reviewboard.kde.org/r/122012/#comment51348> I must delete this pointer after use, otherwise there will be a memory leak. vpn/openconnect/openconnectwidget.cpp <https://git.reviewboard.kde.org/r/122012/#comment51349> Same here. - Lamarque Souza On Jan. 12, 2015, 11:35 a.m., Jan Grulich wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/122012/ > ----------------------------------------------------------- > > (Updated Jan. 12, 2015, 11:35 a.m.) > > > Review request for Network Management, Lukáš Tinkl and Lamarque Souza. > > > Repository: plasma-nm > > > Description > ------- > > This patch adds support for storing secrets to KWallet from Openconnect auth > dialog, which is the only part where secrets could be stored. It should > behave similar to nm-openconnect, which means that all secrets which are > OC_FORM_OPT_PASSWORD are stored to KWallet or they are not stored at all. I > know I should avoid using synchronous calls when opening KWallet, but in this > case it would be probably complicated to use it asynchronously. > > > Diffs > ----- > > kded/passworddialog.cpp 96cc789 > libs/editor/connectiondetaileditor.cpp ee9bced > libs/editor/widgets/settingwidget.h 8d07b73 > libs/editor/widgets/settingwidget.cpp c876e79 > vpn/openconnect/openconnectauth.cpp ebce2be > vpn/openconnect/openconnectwidget.cpp f9bc3cf > > Diff: https://git.reviewboard.kde.org/r/122012/diff/ > > > Testing > ------- > > > Thanks, > > Jan Grulich > >
_______________________________________________ kde-networkmanager mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-networkmanager
