----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122012/#review73940 -----------------------------------------------------------
Ship it! Since the blocking KWallet code is gone, +1 from me - Lukáš Tinkl On Led. 13, 2015, 3:43 odp., Jan Grulich wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/122012/ > ----------------------------------------------------------- > > (Updated Led. 13, 2015, 3:43 odp.) > > > Review request for Network Management, Lukáš Tinkl and Lamarque Souza. > > > Bugs: 309931 and 334474 > http://bugs.kde.org/show_bug.cgi?id=309931 > http://bugs.kde.org/show_bug.cgi?id=334474 > > > Repository: plasma-nm > > > Description > ------- > > This patch adds support for storing secrets to KWallet from Openconnect auth > dialog, which is the only part where secrets could be stored. It should > behave similar to nm-openconnect, which means that all secrets which are > OC_FORM_OPT_PASSWORD are stored to KWallet or they are not stored at all. I > know I should avoid using synchronous calls when opening KWallet, but in this > case it would be probably complicated to use it asynchronously. > > > Diffs > ----- > > kded/secretagent.cpp 67e929f > vpn/openconnect/openconnectauth.cpp ebce2be > vpn/openconnect/openconnectwidget.cpp f9bc3cf > > Diff: https://git.reviewboard.kde.org/r/122012/diff/ > > > Testing > ------- > > > Thanks, > > Jan Grulich > >
_______________________________________________ kde-networkmanager mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-networkmanager
