----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125281/#review85566 -----------------------------------------------------------
libs/editor/listvalidator.h (line 43) <https://git.reviewboard.kde.org/r/125281/#comment59130> This variable is not used anywhere. libs/editor/listvalidator.cpp (line 27) <https://git.reviewboard.kde.org/r/125281/#comment59131> , inner(nullptr) libs/editor/listvalidator.cpp (line 39) <https://git.reviewboard.kde.org/r/125281/#comment59133> I think this one can be const. libs/editor/listvalidator.cpp (line 40) <https://git.reviewboard.kde.org/r/125281/#comment59134> trash? Qt documentation calls QValidate::validate()'s second parameter pos. It looks a better name than trash. You can add a comment stating this is not actually used, just that validate() requires a second parameter. libs/editor/listvalidator.cpp (line 42) <https://git.reviewboard.kde.org/r/125281/#comment59132> Use const_iterator, constBegin(), constEnd() and ++i: for (QStringList::const_iterator i = strings.constBegin(); i != strings.constEnd(); ++i) libs/editor/listvalidator.cpp (line 43) <https://git.reviewboard.kde.org/r/125281/#comment59135> This and the next two variables can be constas well. libs/editor/settings/security802-1x.cpp (line 245) <https://git.reviewboard.kde.org/r/125281/#comment59137> Code style: if (...) { } libs/editor/settings/security802-1x.cpp (line 406) <https://git.reviewboard.kde.org/r/125281/#comment59139> "Connect to these servers only" libs/editor/settings/ui/802-1x.ui (line 637) <https://git.reviewboard.kde.org/r/125281/#comment59138> If I am not mistaken we should use QComboBox instead of KComboBox, right? - Lamarque Souza On Sept. 17, 2015, 8:03 a.m., Jan Grulich wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125281/ > ----------------------------------------------------------- > > (Updated Sept. 17, 2015, 8:03 a.m.) > > > Review request for Network Management, Lukáš Tinkl and Lamarque Souza. > > > Bugs: 342728 > http://bugs.kde.org/show_bug.cgi?id=342728 > > > Repository: plasma-nm > > > Description > ------- > > 1) Adds options to set subjectMatch and altSubjectMatch properties (taken > from the old NM applet) > - bug 342728 - Security bug/Regression: altSubjectMatch disappeared with > the move to plasma-nm > > 2) Adds WPA/WPA2 Enterprise validation (done according to > nm-connection-editor). It's not complete for TLS, I found out that we need to > also check private key and get its format to know whether we need client > certificate or not, because it might be set already by private key if it's in > NM_SETTING_802_1X_CK_FORMAT_PKCS12 format. I would need more time to > implement this and verify if I implemented it correctly so that's why I'm > sending this part to review first. This should also fix bug 351191 where I > think that the problem is that we don't set client certificate if private key > is in NM_SETTING_802_1X_CK_FORMAT_PKCS12 format. > > > Diffs > ----- > > libs/editor/CMakeLists.txt 22b7eca > libs/editor/listvalidator.h PRE-CREATION > libs/editor/listvalidator.cpp PRE-CREATION > libs/editor/settings/security802-1x.h 22c78fa > libs/editor/settings/security802-1x.cpp 0f8f71d > libs/editor/settings/ui/802-1x.ui ac5732a > libs/editor/settings/wifisecurity.cpp b2b80fb > libs/editor/widgets/editlistdialog.h PRE-CREATION > libs/editor/widgets/editlistdialog.cpp PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/125281/diff/ > > > Testing > ------- > > > Thanks, > > Jan Grulich > >
_______________________________________________ kde-networkmanager mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-networkmanager
