-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125281/
-----------------------------------------------------------
(Updated Zář. 18, 2015, 10:31 dop.)
Review request for Network Management, Lukáš Tinkl and Lamarque Souza.
Changes
-------
Fixed mentioned issues.
Bugs: 342728
http://bugs.kde.org/show_bug.cgi?id=342728
Repository: plasma-nm
Description
-------
1) Adds options to set subjectMatch and altSubjectMatch properties (taken from
the old NM applet)
- bug 342728 - Security bug/Regression: altSubjectMatch disappeared with the
move to plasma-nm
2) Adds WPA/WPA2 Enterprise validation (done according to
nm-connection-editor). It's not complete for TLS, I found out that we need to
also check private key and get its format to know whether we need client
certificate or not, because it might be set already by private key if it's in
NM_SETTING_802_1X_CK_FORMAT_PKCS12 format. I would need more time to implement
this and verify if I implemented it correctly so that's why I'm sending this
part to review first. This should also fix bug 351191 where I think that the
problem is that we don't set client certificate if private key is in
NM_SETTING_802_1X_CK_FORMAT_PKCS12 format.
Diffs (updated)
-----
libs/editor/CMakeLists.txt 22b7eca
libs/editor/listvalidator.h PRE-CREATION
libs/editor/listvalidator.cpp PRE-CREATION
libs/editor/settings/security802-1x.h 22c78fa
libs/editor/settings/security802-1x.cpp 0f8f71d
libs/editor/settings/ui/802-1x.ui ac5732a
libs/editor/settings/wifisecurity.cpp b2b80fb
libs/editor/widgets/editlistdialog.h PRE-CREATION
libs/editor/widgets/editlistdialog.cpp PRE-CREATION
Diff: https://git.reviewboard.kde.org/r/125281/diff/
Testing
-------
Thanks,
Jan Grulich
_______________________________________________
kde-networkmanager mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/kde-networkmanager
