----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129111/#review99809 -----------------------------------------------------------
vpn/iodine/iodine.h (line 34) <https://git.reviewboard.kde.org/r/129111/#comment67082> You should use Q_DECL_OVERRIDE here instead of virtual. The same applies to all methods below. vpn/iodine/iodine.ui (line 31) <https://git.reviewboard.kde.org/r/129111/#comment67088> This should be a spinbox to prevent users from typing non-digit characters and negative numbers. vpn/iodine/iodineauth.h (line 35) <https://git.reviewboard.kde.org/r/129111/#comment67084> nullptr instead of 0? Or is Q_NULLPTR still recommended? vpn/iodine/iodineauth.h (line 37) <https://git.reviewboard.kde.org/r/129111/#comment67083> Q_DECL_OVERRIDE vpn/iodine/iodinewidget.h (line 40) <https://git.reviewboard.kde.org/r/129111/#comment67085> Q_DECL_OVERRIDE here and all lines below. vpn/iodine/iodinewidget.cpp (line 57) <https://git.reviewboard.kde.org/r/129111/#comment67086> setting is passed to loadSecrets() at the end of this method, so this line is not needed. vpn/iodine/iodinewidget.cpp (line 140) <https://git.reviewboard.kde.org/r/129111/#comment67087> Only toplevelDomain is required? Shouldn't nameserver and password also be required? It does not make sense to create a vpn without password. - Lamarque Souza On Oct. 6, 2016, 11:09 a.m., Jan Grulich wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129111/ > ----------------------------------------------------------- > > (Updated Oct. 6, 2016, 11:09 a.m.) > > > Review request for Network Management and Lamarque Souza. > > > Bugs: 367655 > http://bugs.kde.org/show_bug.cgi?id=367655 > > > Repository: plasma-nm > > > Description > ------- > > This patch adds support for Iodine VPN connections allowing tunnel > connections via DNS. > > > Diffs > ----- > > vpn/CMakeLists.txt 3d3f962 > vpn/iodine/CMakeLists.txt PRE-CREATION > vpn/iodine/Messages.sh PRE-CREATION > vpn/iodine/iodine.h PRE-CREATION > vpn/iodine/iodine.cpp PRE-CREATION > vpn/iodine/iodine.ui PRE-CREATION > vpn/iodine/iodineauth.h PRE-CREATION > vpn/iodine/iodineauth.cpp PRE-CREATION > vpn/iodine/iodineauth.ui PRE-CREATION > vpn/iodine/iodinewidget.h PRE-CREATION > vpn/iodine/iodinewidget.cpp PRE-CREATION > vpn/iodine/nm-iodine-service.h PRE-CREATION > vpn/iodine/plasmanetworkmanagement_iodineui.desktop PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/129111/diff/ > > > Testing > ------- > > > Thanks, > > Jan Grulich > >
