> On Říj. 6, 2016, 1:23 odp., Lamarque Souza wrote: > > vpn/iodine/iodine.ui, line 31 > > <https://git.reviewboard.kde.org/r/129111/diff/1/?file=481763#file481763line31> > > > > This should be a spinbox to prevent users from typing non-digit > > characters and negative numbers. > > Jan Grulich wrote: > I implemented this exactly the same way as it is implemented in > nm-connection-editor. Do you have idea what would be the minimum and maximum > value for this? I couldn't find it in the source code for > NetworkManager-iodine plugin. > > Lamarque Souza wrote: > I have not found that either. What I have found is that that number is > like MTU for ethernet and the smaller that number the more overhead the > connection will have. The maximum value should not be big since DNS' packets > are not supposed to have a big payload, maybe 2 kbytes at the very most. It > is also calculated automatically when it is not set, so maybe we sould add a > hint saying that the user should not set that option and allow it to be > calculcated automatically for better performance.
I changed the line edit to spinbox with minimum value to be 0 (Automatic) and maximum value 10000 (according to MTU for ethernet). - Jan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129111/#review99809 ----------------------------------------------------------- On Říj. 6, 2016, 11:09 dop., Jan Grulich wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129111/ > ----------------------------------------------------------- > > (Updated Říj. 6, 2016, 11:09 dop.) > > > Review request for Network Management and Lamarque Souza. > > > Bugs: 367655 > http://bugs.kde.org/show_bug.cgi?id=367655 > > > Repository: plasma-nm > > > Description > ------- > > This patch adds support for Iodine VPN connections allowing tunnel > connections via DNS. > > > Diffs > ----- > > vpn/CMakeLists.txt 3d3f962 > vpn/iodine/CMakeLists.txt PRE-CREATION > vpn/iodine/Messages.sh PRE-CREATION > vpn/iodine/iodine.h PRE-CREATION > vpn/iodine/iodine.cpp PRE-CREATION > vpn/iodine/iodine.ui PRE-CREATION > vpn/iodine/iodineauth.h PRE-CREATION > vpn/iodine/iodineauth.cpp PRE-CREATION > vpn/iodine/iodineauth.ui PRE-CREATION > vpn/iodine/iodinewidget.h PRE-CREATION > vpn/iodine/iodinewidget.cpp PRE-CREATION > vpn/iodine/nm-iodine-service.h PRE-CREATION > vpn/iodine/plasmanetworkmanagement_iodineui.desktop PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/129111/diff/ > > > Testing > ------- > > > Thanks, > > Jan Grulich > >
