----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101011/#review2320 -----------------------------------------------------------
account-button.cpp <http://git.reviewboard.kde.org/r/101011/#comment2016> should this code not happen in presenceChanged too? I'm seeing this as trying to handle not-listed presence states? account-button.cpp <http://git.reviewboard.kde.org/r/101011/#comment2018> This icon generation really needs to happen in presenceChanged too. Suggestion, change this code to be: foreach(QAction *a, actions()) { setCheckable(true); } onPresenceChnaged(m_account->currentPresence()); account-button.cpp <http://git.reviewboard.kde.org/r/101011/#comment2015> Is this actually true/working? actions().last() is now be the presenceMessageAction. also I don't really like duplicating code. suggestion: presenceChanged(Presence::offline()); maybe? - David On April 2, 2011, 6:13 p.m., Martin Klapetek wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/101011/ > ----------------------------------------------------------- > > (Updated April 2, 2011, 6:13 p.m.) > > > Review request for Telepathy. > > > Summary > ------- > > Add a possibility to set a different status message per account. If the > status message is changed from CL's main status line edit, this gets changed > as well. Plus some minor fixes/improvements in AccountButton. > > > Diffs > ----- > > account-button.h c5ac84a5ea53a1ec534efe6580e6cbf321c2e599 > account-button.cpp 7a5f27d7ddc459c65d1c97d11c7e946343dc33c2 > > Diff: http://git.reviewboard.kde.org/r/101011/diff > > > Testing > ------- > > I set status in the new klineedit, user see it. I overwrite this with the > main klineedit presence and users see it again. > > > Thanks, > > Martin > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
