> On April 2, 2011, 7:32 p.m., David Edmundson wrote: > > account-button.cpp, line 130 > > <http://git.reviewboard.kde.org/r/101011/diff/1/?file=13699#file13699line130> > > > > should this code not happen in presenceChanged too? > > I'm seeing this as trying to handle not-listed presence states? > > > > > > Martin Klapetek wrote: > I always thought that it's not a problem because there can't be set a > non-listed/non-existing presence state, but now that you pointed it out, yes, > it should be there as well. Though in that case there is a bigger issue - > shouldn't the account itself be reset to some known presence then? For > example offline?
I think comes from a slightly more overall problem of: 1) presences being surprisingly complicated 2) this code not having profile support - we should be asking the account what presences it has when generating the list of options (account()->profile()->presences(); ), but that's for another patch. - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101011/#review2320 ----------------------------------------------------------- On April 2, 2011, 6:13 p.m., Martin Klapetek wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/101011/ > ----------------------------------------------------------- > > (Updated April 2, 2011, 6:13 p.m.) > > > Review request for Telepathy. > > > Summary > ------- > > Add a possibility to set a different status message per account. If the > status message is changed from CL's main status line edit, this gets changed > as well. Plus some minor fixes/improvements in AccountButton. > > > Diffs > ----- > > account-button.h c5ac84a5ea53a1ec534efe6580e6cbf321c2e599 > account-button.cpp 7a5f27d7ddc459c65d1c97d11c7e946343dc33c2 > > Diff: http://git.reviewboard.kde.org/r/101011/diff > > > Testing > ------- > > I set status in the new klineedit, user see it. I overwrite this with the > main klineedit presence and users see it again. > > > Thanks, > > Martin > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
