> On April 5, 2011, 2:53 p.m., David Edmundson wrote: > > main-widget.cpp, line 652 > > <http://git.reviewboard.kde.org/r/101032/diff/1/?file=13796#file13796line652> > > > > This method is exactly the same as: > > slotRemoveContactFromGroupFinished > > slotUnblockContactFinished > > slotBlockContactFinsihed > > > > and possibly some more. > > > > Can I suggest we make a > > slotGenericOperionFinished() method and just connect anything with no > > special functionality to do that. > > > > That might be outside the scope of this patch. > >
I can easily integrate the "slotGenericOperionFinished()" to this patch. I don't think it's worth a seperate patch > On April 5, 2011, 2:53 p.m., David Edmundson wrote: > > main-widget.cpp, line 645 > > <http://git.reviewboard.kde.org/r/101032/diff/1/?file=13796#file13796line645> > > > > [14:53] <oggis_> actually removing both from subscribe and publish > > should be done usually when "removing a friend" > > > > we should call removePresencePublication too. > > > > This may fix your CM issues. isn't that what block does? > On April 5, 2011, 2:53 p.m., David Edmundson wrote: > > main-widget.cpp, line 649 > > <http://git.reviewboard.kde.org/r/101032/diff/1/?file=13796#file13796line649> > > > > I'm not convinced we should call "block" here, as it just makes the > > other method "block" somewhat redundant. see above on why i used block > On April 5, 2011, 2:53 p.m., David Edmundson wrote: > > main-widget.cpp, line 640 > > <http://git.reviewboard.kde.org/r/101032/diff/1/?file=13796#file13796line640> > > > > shure -> sure > > > > I think "delete" is a bit of a strong word, "Remove" might be better. > > stupid grammar error. Changing to "Remove" - Francesco ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101032/#review2398 ----------------------------------------------------------- On April 5, 2011, 2:36 p.m., Francesco Nwokeka wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/101032/ > ----------------------------------------------------------- > > (Updated April 5, 2011, 2:36 p.m.) > > > Review request for Telepathy. > > > Summary > ------- > > Implemented the "Delete user" action in the context menu of the contact list. > The "delete" action removes the contact and blocks it. > > For the moment this does not work 100% on all CM's but will as soon as things > upstream are completley implemented/handled > > > Diffs > ----- > > main-widget.h 6c45763 > main-widget.cpp 99c6761 > > Diff: http://git.reviewboard.kde.org/r/101032/diff > > > Testing > ------- > > Deleted a contact from google talk. > > Doesn't work with butterfly CM. > > > Thanks, > > Francesco > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
