> On April 5, 2011, 4:36 p.m., Martin Klapetek wrote: > > Isn`t removing AND blocking a bit dangerous? If you re-add the deleted (and > > blocked) contact, will it still be blocked? If so, you need to omit the > > blocking. > > David Edmundson wrote: > Not really - as long as we show an icon on a user to show it's blocked. > They'll be re-added but you'll still see their blocked. > > Martin Klapetek wrote: > Ok, then why block it at all?
Because if you remove a contact i don't think you'd want that contact re-adding you or writing to you again. Anyway I'm creating a custom dialog with a checkbox to enable the blocking feature so the user can choose if he/she wants to block the contact as well upon removal.( suggested by oggis ) - Francesco ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101032/#review2405 ----------------------------------------------------------- On April 5, 2011, 2:36 p.m., Francesco Nwokeka wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/101032/ > ----------------------------------------------------------- > > (Updated April 5, 2011, 2:36 p.m.) > > > Review request for Telepathy. > > > Summary > ------- > > Implemented the "Delete user" action in the context menu of the contact list. > The "delete" action removes the contact and blocks it. > > For the moment this does not work 100% on all CM's but will as soon as things > upstream are completley implemented/handled > > > Diffs > ----- > > main-widget.h 6c45763 > main-widget.cpp 99c6761 > > Diff: http://git.reviewboard.kde.org/r/101032/diff > > > Testing > ------- > > Deleted a contact from google talk. > > Doesn't work with butterfly CM. > > > Thanks, > > Francesco > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
