> On April 11, 2011, 12:10 p.m., David Edmundson wrote: > > First change is fine, > > As for dealing with <br/> issues, would it work if we just put this code in > > AdiumThemeView before we replace out \n with <br/>? > > > > If it makes life easier/code shorter, we could go with that. Your choice.
As said in irc, I find it cleaner to do this operation in the same place we look for the url instead of acting in two different places. - Francesco ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101080/#review2555 ----------------------------------------------------------- On April 11, 2011, 9:57 a.m., Francesco Nwokeka wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/101080/ > ----------------------------------------------------------- > > (Updated April 11, 2011, 9:57 a.m.) > > > Review request for Telepathy. > > > Summary > ------- > > Simple patch to recognize other links other than http(s). Added smb and > (s)ftp. if there are others to add please let me know > > > This addresses bug 270345. > http://bugs.kde.org/show_bug.cgi?id=270345 > > > Diffs > ----- > > lib/adium-theme-view.cpp 3cd889f > > Diff: http://git.reviewboard.kde.org/r/101080/diff > > > Testing > ------- > > > Thanks, > > Francesco > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
