> On April 14, 2011, 10:21 a.m., Rohan Garg wrote:
> > Correct me if I am wrong, but won't it be better to use
> > KProtocolInfo::isKnownProtocol here instead of doing things manually
>
> Francesco Nwokeka wrote:
> Where?if you refer to line 365 then that's not possible. The url is
> "hidden" inside a blob of html code. That means I have to search for the url
> patterns and send it to the chat as a link otherwise it's not recognized.
>
> Rohan Garg wrote:
> Ah okay, KProtocolInfo can also provide you with a list of known
> protocols, maybe that can be used and used along.with the regex?
That list would give me a list of protocols known to my system. Whilst links
passed in a chat are web-based. This is what KProtocolInfo::protocols() returns
on my system
("rtsp", "mmst", "tomahawk", "mmsu", "sftp", "imaps", "zip", "skype", "mbox",
"ms-its", "pnm", "timeline", "itpc", "data", "mms", "adiumxtra", "help",
"videodvd", "nepomuk", "aim", "sieve", "finger", "lastfm", "metainfo", "bzip",
"desktop", "fish", "bookmarks", "floppy", "nfs", "webcal", "lzma", "info",
"filenamesearch", "irc6", "webdav", "ftp", "nntp", "nepomuksearch", "tar",
"file", "pop3s", "applications", "network", "http", "ldaps", "ghelp", "amarok",
"settings", "xz", "xmpp", "gzip", "audiocd", "rtspt", "rtspu", "man", "fonts",
"ar", "feed", "trash", "smtp", "imap", "bzip2", "smb", "akonadi", "https",
"webdavs", "cgi", "tel", "nntps", "irc", "callto", "pop3", "programs", "about",
"thumbnail", "smtps", "ldap", "remote")
So I don't think that'd be useful
- Francesco
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101080/#review2631
-----------------------------------------------------------
On April 14, 2011, 9:38 a.m., Francesco Nwokeka wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101080/
> -----------------------------------------------------------
>
> (Updated April 14, 2011, 9:38 a.m.)
>
>
> Review request for Telepathy.
>
>
> Summary
> -------
>
> Simple patch to recognize other links other than http(s). Added smb and
> (s)ftp. if there are others to add please let me know
>
>
> This addresses bug 270345.
> http://bugs.kde.org/show_bug.cgi?id=270345
>
>
> Diffs
> -----
>
> lib/adium-theme-view.cpp 8a8818c
>
> Diff: http://git.reviewboard.kde.org/r/101080/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Francesco
>
>
_______________________________________________
KDE-Telepathy mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/kde-telepathy
