----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101121/#review2641 -----------------------------------------------------------
Ship it! Looks great, but watch out for whitespaces! Do you have a git account already or should I commit that for you? main-widget.cpp <http://git.reviewboard.kde.org/r/101121/#comment2335> Watch out for whitespaces main-widget.cpp <http://git.reviewboard.kde.org/r/101121/#comment2336> Whitespaces - Dario On April 14, 2011, 1:28 p.m., Nicolas Lécureuil wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/101121/ > ----------------------------------------------------------- > > (Updated April 14, 2011, 1:28 p.m.) > > > Review request for Telepathy. > > > Summary > ------- > > This patch remove the QActions from the ui file and add them on the cpp file > to allow us to use KAction and KStandardShortcut and thus use the standard > KDE shortcuts. > > > Diffs > ----- > > main-widget.h 18f97ee > main-widget.cpp 7fe200c > main-widget.ui d000b9b > > Diff: http://git.reviewboard.kde.org/r/101121/diff > > > Testing > ------- > > I tested with standard shortcut ( Ctrl +F ) + changed the shortcut in > systemsettings and retested in telepathy-contact-list to see that it was > using new shortcut ( Ctrl + J ) for my test. > > > Thanks, > > Nicolas > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
