> On April 14, 2011, 1:36 p.m., George Kiagiadakis wrote: > > main-widget.cpp, lines 118-119 > > <http://git.reviewboard.kde.org/r/101121/diff/1/?file=14382#file14382line118> > > > > I wonder why on all actions you define a text in the constructor and > > then you call setText(QString()). What's the point of that?
i removed this in a later commit. - Nicolas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101121/#review2644 ----------------------------------------------------------- On April 14, 2011, 1:28 p.m., Nicolas Lécureuil wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/101121/ > ----------------------------------------------------------- > > (Updated April 14, 2011, 1:28 p.m.) > > > Review request for Telepathy. > > > Summary > ------- > > This patch remove the QActions from the ui file and add them on the cpp file > to allow us to use KAction and KStandardShortcut and thus use the standard > KDE shortcuts. > > > Diffs > ----- > > main-widget.h 18f97ee > main-widget.cpp 7fe200c > main-widget.ui d000b9b > > Diff: http://git.reviewboard.kde.org/r/101121/diff > > > Testing > ------- > > I tested with standard shortcut ( Ctrl +F ) + changed the shortcut in > systemsettings and retested in telepathy-contact-list to see that it was > using new shortcut ( Ctrl + J ) for my test. > > > Thanks, > > Nicolas > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
