> On April 28, 2011, 4:20 p.m., David Edmundson wrote: > > app/chat-window.cpp, line 97 > > <http://git.reviewboard.kde.org/r/101250/diff/1/?file=15575#file15575line97> > > > > qDebug -> kDebug > > > > AND AVOID TYPING ALL IN CAPS :-P
sorry, my debug messages. eliminating > On April 28, 2011, 4:20 p.m., David Edmundson wrote: > > app/chat-window.cpp, line 94 > > <http://git.reviewboard.kde.org/r/101250/diff/1/?file=15575#file15575line94> > > > > I think by comparing targetHandleType we can work for room chats too. > > I don't think we need to restrict to 1-1 chats. > > > > The bug report also says to not check for dupes in which the new > > channel targetHandleType is HandleTypeNone and always make a new window for > > them. in fact I look for both. First "&& auxChatTab->textChannel()->targetHandleType() == Tp::HandleTypeContact" then I have to handle a 1on1 chat otherwise if the handle == Tp::HandleTypeGroup then I'll handle the group chat. Modifying - Francesco ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101250/#review2945 ----------------------------------------------------------- On April 28, 2011, 3:32 p.m., Francesco Nwokeka wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/101250/ > ----------------------------------------------------------- > > (Updated April 28, 2011, 3:32 p.m.) > > > Review request for Telepathy. > > > Summary > ------- > > Part1 of resolving bug 270725. I made two setup methods that have the task to > setup the connections of the chatWidget's Tp::textChannelPtr. This was done > to facilitate my work later on when substituting the old textptr with a new > one when the user comes back online and he/she had an ongoing chat. > Plus you can see that I changed the mathing criteria. I no longer match the > textChannelPtr, but the targetId and it's handler. > > > Diffs > ----- > > app/chat-window.h 8a55655 > app/chat-window.cpp ca1778a > lib/chat-widget.h f357aea > lib/chat-widget.cpp b483436 > > Diff: http://git.reviewboard.kde.org/r/101250/diff > > > Testing > ------- > > Opened chats with contacts and the behaviour was like before > > > Thanks, > > Francesco > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
