> On April 28, 2011, 4:20 p.m., David Edmundson wrote: > > app/chat-window.cpp, line 95 > > <http://git.reviewboard.kde.org/r/101250/diff/1/?file=15575#file15575line95> > > > > auxChatTab->textChannel()->targetId() /might/ not work. > > > > at this point, auxChatTab->textChannel() returns an invalidated channel. > > > > Does this still contain a working targetId and targetHandleType, or > > does it now report nonsense? It may, it may not. I don't know. > > Needs either testing asking oggis or looking in Tp-Qt4 code. > > Francesco Nwokeka wrote: > Asking in #telepathy > > <nwoki> hi guys. if i call targetId() from an invalidated textChannelPtr, > do I get a valid value or is it old and broken and send me into segfault? > <danni> nwoki: not that I know tp-qt4, but I'd expect you could still > retrieve the values stored in the proxy > <danni> but nothing that would make a dbus call > <nwoki> danni: yeah, i just need info. don't need to make dbus calls > <danni> I'd expect it to work then
Tested with output and returns the correct targetId - Francesco ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101250/#review2945 ----------------------------------------------------------- On April 28, 2011, 3:32 p.m., Francesco Nwokeka wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/101250/ > ----------------------------------------------------------- > > (Updated April 28, 2011, 3:32 p.m.) > > > Review request for Telepathy. > > > Summary > ------- > > Part1 of resolving bug 270725. I made two setup methods that have the task to > setup the connections of the chatWidget's Tp::textChannelPtr. This was done > to facilitate my work later on when substituting the old textptr with a new > one when the user comes back online and he/she had an ongoing chat. > Plus you can see that I changed the mathing criteria. I no longer match the > textChannelPtr, but the targetId and it's handler. > > > Diffs > ----- > > app/chat-window.h 8a55655 > app/chat-window.cpp ca1778a > lib/chat-widget.h f357aea > lib/chat-widget.cpp b483436 > > Diff: http://git.reviewboard.kde.org/r/101250/diff > > > Testing > ------- > > Opened chats with contacts and the behaviour was like before > > > Thanks, > > Francesco > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
