----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101303/#review3157 -----------------------------------------------------------
Ship it! I think it's ok for now, but later we should investigate the Tp::Connection::ErrorDetails class, especially the invalidationReason() -- from the docs: "The information provided by invalidationReason() and this class [ErrorDetails] should always be used in error handling in preference to statusReason(). The status reason can be used as a fallback, however, if the client doesn't understand what a particular value returned by invalidationReason() means, as it may be domain-specific with some services." - Martin On May 6, 2011, 8:40 a.m., Francesco Nwokeka wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/101303/ > ----------------------------------------------------------- > > (Updated May 6, 2011, 8:40 a.m.) > > > Review request for Telepathy. > > > Summary > ------- > > Simple patch to connect the connection errors and obtain a notification for > the user so that he/she knows what's going on > > > Diffs > ----- > > main-widget.h 396c08b > main-widget.cpp 2a00fab > > Diff: http://git.reviewboard.kde.org/r/101303/diff > > > Testing > ------- > > Tried to connect to networks without password and wrong login > > > Thanks, > > Francesco > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
