> On May 7, 2011, 7:44 a.m., Francesco Nwokeka wrote: > > main-widget.cpp, lines 1124-1127 > > <http://git.reviewboard.kde.org/r/101303/diff/1/?file=16206#file16206line1124> > > > > This part of code is activated for all other errors that occur. It is > > also activated on "disconnect" of the CM > > ("org.freedesktop.Telepathy.Error.Cancelled"). Is that ok with you? > >
I'm just a bit worried about the messages we'll get from that. We should prepend it with something like "An unexpected error has occured: %1" or something. Also, it should be a SystemMessageError type. As for being enough instead of the invalidationReason() - I'd like to hear opinion from tp-qt4 devs. Can anyone please comment? - Martin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101303/#review3192 ----------------------------------------------------------- On May 6, 2011, 8:40 a.m., Francesco Nwokeka wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/101303/ > ----------------------------------------------------------- > > (Updated May 6, 2011, 8:40 a.m.) > > > Review request for Telepathy. > > > Summary > ------- > > Simple patch to connect the connection errors and obtain a notification for > the user so that he/she knows what's going on > > > Diffs > ----- > > main-widget.h 396c08b > main-widget.cpp 2a00fab > > Diff: http://git.reviewboard.kde.org/r/101303/diff > > > Testing > ------- > > Tried to connect to networks without password and wrong login > > > Thanks, > > Francesco > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
