> On June 24, 2011, 7:21 p.m., David Edmundson wrote: > > dialogs/join-chat-room-dialog.cpp, line 32 > > <http://git.reviewboard.kde.org/r/101751/diff/1/?file=25162#file25162line32> > > > > Why do this? > > > > You can replace those 4 lines with > > > > ui->setupUi(this);
Using the "setupUi(this)" method disabled the KDialog and messes up the widget layout. This method is used also on the other dialogs > On June 24, 2011, 7:21 p.m., David Edmundson wrote: > > main-widget.cpp, line 1232 > > <http://git.reviewboard.kde.org/r/101751/diff/1/?file=25164#file25164line1232> > > > > that's the weirdest account of "account" I've ever seen. > > > > Also remove this debug line, or at least make it use kDebug My bad, forgot to remove this - Francesco ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101751/#review4129 ----------------------------------------------------------- On June 24, 2011, 6:54 p.m., Francesco Nwokeka wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/101751/ > ----------------------------------------------------------- > > (Updated June 24, 2011, 6:54 p.m.) > > > Review request for Telepathy. > > > Summary > ------- > > Adds an action under the "wrench" button to join a chat group. Only online > accounts with this capability are listed. > > > Diffs > ----- > > CMakeLists.txt 3dd8cc0 > dialogs/join-chat-room-dialog.h PRE-CREATION > dialogs/join-chat-room-dialog.cpp PRE-CREATION > main-widget.h 5625778 > main-widget.cpp f19cbee > > Diff: http://git.reviewboard.kde.org/r/101751/diff > > > Testing > ------- > > > Thanks, > > Francesco > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
