----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101751/#review4192 -----------------------------------------------------------
Is the wrench button the right place to place "Join chat room" button/menu item? Because that wrench is for settings and thus only settings should go there, it doesn't make sense to have "Join chat room" there. - Martin On June 24, 2011, 9:43 p.m., Francesco Nwokeka wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/101751/ > ----------------------------------------------------------- > > (Updated June 24, 2011, 9:43 p.m.) > > > Review request for Telepathy. > > > Summary > ------- > > Adds an action under the "wrench" button to join a chat group. Only online > accounts with this capability are listed. > > > Diffs > ----- > > CMakeLists.txt 3dd8cc0 > dialogs/join-chat-room-dialog.h PRE-CREATION > dialogs/join-chat-room-dialog.cpp PRE-CREATION > main-widget.h 5625778 > main-widget.cpp f19cbee > > Diff: http://git.reviewboard.kde.org/r/101751/diff > > > Testing > ------- > > > Thanks, > > Francesco > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
