----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102972/#review7656 -----------------------------------------------------------
src/KCMTelepathyAccounts/account-edit-widget.cpp <http://git.reviewboard.kde.org/r/102972/#comment6609> No! You can't have protocol specific code in the main code area. src/add-account-assistant.cpp <http://git.reviewboard.kde.org/r/102972/#comment6610> "All fields must be filled". This isn't always true, it means one failed validation. Validation could be checking an email address is formatted like an email address or such. - David Edmundson On Oct. 26, 2011, 10:06 a.m., Francesco Nwokeka wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/102972/ > ----------------------------------------------------------- > > (Updated Oct. 26, 2011, 10:06 a.m.) > > > Review request for Telepathy. > > > Description > ------- > > This patch checks that both fields have been filled when adding a facebook > account. > > > This addresses bug 279110. > http://bugs.kde.org/show_bug.cgi?id=279110 > > > Diffs > ----- > > src/KCMTelepathyAccounts/account-edit-widget.cpp 1823501 > src/add-account-assistant.cpp 3614cc6 > > Diff: http://git.reviewboard.kde.org/r/102972/diff/diff > > > Testing > ------- > > Tried to create an account with empty values. Got prompted to fill fields > > > Thanks, > > Francesco Nwokeka > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
