> On Oct. 26, 2011, 5:27 p.m., David Edmundson wrote: > > src/add-account-assistant.cpp, line 157 > > <http://git.reviewboard.kde.org/r/102972/diff/2/?file=39775#file39775line157> > > > > This needs changing. See last review.
"All mandatory fields must be filled" - Francesco ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102972/#review7657 ----------------------------------------------------------- On Oct. 26, 2011, 11:06 a.m., Francesco Nwokeka wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/102972/ > ----------------------------------------------------------- > > (Updated Oct. 26, 2011, 11:06 a.m.) > > > Review request for Telepathy. > > > Description > ------- > > This patch checks that both fields have been filled when adding a facebook > account. > > > This addresses bug 279110. > http://bugs.kde.org/show_bug.cgi?id=279110 > > > Diffs > ----- > > plugins/gabble/main-options-widget-facebook.h 0f5f42f > plugins/gabble/main-options-widget-facebook.cpp 7f6ef22 > src/add-account-assistant.cpp 3614cc6 > > Diff: http://git.reviewboard.kde.org/r/102972/diff/diff > > > Testing > ------- > > Tried to create an account with empty values. Got prompted to fill fields > > > Thanks, > > Francesco Nwokeka > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
