-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103118/#review8137
-----------------------------------------------------------



main-widget.cpp
<http://git.reviewboard.kde.org/r/103118/#comment6976>

    QAction -> KAction
    
    Fix your Capitalisation. Either have It all Title case or Not.
    (Actually I think UI rules state it should be sentence case.)



main-widget.cpp
<http://git.reviewboard.kde.org/r/103118/#comment6978>

    Telepathy does support blocking. In fact we use it in 'remove'. (there was 
an issue in butterfly at one point, but that's fairly irrelevant now.)
    
    Can we sort this out in a separate commit sometime.
    
    



main-widget.cpp
<http://git.reviewboard.kde.org/r/103118/#comment6977>

    I know this is technically just moved code, but QAction->KAction
    


- David Edmundson


On Nov. 12, 2011, 12:31 p.m., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103118/
> -----------------------------------------------------------
> 
> (Updated Nov. 12, 2011, 12:31 p.m.)
> 
> 
> Review request for Telepathy and Dario Freddi.
> 
> 
> Description
> -------
> 
> As description
> 
> 
> Diffs
> -----
> 
>   main-widget.h f602a3a 
>   main-widget.cpp ab37eb0 
> 
> Diff: http://git.reviewboard.kde.org/r/103118/diff/diff
> 
> 
> Testing
> -------
> 
> Works.
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

_______________________________________________
KDE-Telepathy mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/kde-telepathy

Reply via email to