> On Nov. 12, 2011, 7:46 p.m., Dario Freddi wrote: > > Fine to me. Mind you, you probably forgot to git add the new file you > > added, since it doesn't appear in the review. Given it's an external file, > > from what I understood, fine this way.
No, it's all, the file in common/ is part of the git submodule (telepathy-common-internals) and that's where the file actually is, it was review few days back -- https://git.reviewboard.kde.org/r/103018/ - Martin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103118/#review8161 ----------------------------------------------------------- On Nov. 12, 2011, 5:30 p.m., Martin Klapetek wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/103118/ > ----------------------------------------------------------- > > (Updated Nov. 12, 2011, 5:30 p.m.) > > > Review request for Telepathy and Dario Freddi. > > > Description > ------- > > As description > > > Diffs > ----- > > CMakeLists.txt 9bc4171 > main-widget.h f602a3a > main-widget.cpp ab37eb0 > > Diff: http://git.reviewboard.kde.org/r/103118/diff/diff > > > Testing > ------- > > Works. > > > Thanks, > > Martin Klapetek > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
