> On Nov. 28, 2011, 5:01 p.m., Dario Freddi wrote: > > plugins/haze/yahoo-main-options-widget.cpp, lines 56-57 > > <http://git.reviewboard.kde.org/r/103281/diff/1/?file=42357#file42357line56> > > > > Nitpick: do you think it would make more sense to grep for @yahoo > > instead of just @? Although it's safe to assume @ is a wildcard, I am > > wondering if haze allows people to log in with usernames such as > > user@otherservice.
Well I did it this way because for haze/yahoo it apparently doesn't matter what is beyond the '@' (and it is not allowed character in username), so detecting just '@' and then removing all behind it is sufficient. > On Nov. 28, 2011, 5:01 p.m., Dario Freddi wrote: > > plugins/haze/yahoo-main-options-widget.cpp, lines 58-61 > > <http://git.reviewboard.kde.org/r/103281/diff/1/?file=42357#file42357line58> > > > > You could use a more elegant (and readable) approach by removing the > > remove (haha) and using .left(). So, > > > > parameterModel()->setData(index, account.left(atIndex), Qt::EditRole); Makes sense. - Martin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103281/#review8571 ----------------------------------------------------------- On Nov. 28, 2011, 1:01 p.m., Martin Klapetek wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/103281/ > ----------------------------------------------------------- > > (Updated Nov. 28, 2011, 1:01 p.m.) > > > Review request for Telepathy. > > > Description > ------- > > Haze requires yahoo! account to be without the @yahoo.com part. This patch > removes that part if user adds it. It's imho better to do this than to put a > big scary WARNING! above the line edit. Our software appears smart. > > > This addresses bug 287190. > http://bugs.kde.org/show_bug.cgi?id=287190 > > > Diffs > ----- > > plugins/haze/yahoo-main-options-widget.h 592e582 > plugins/haze/yahoo-main-options-widget.cpp 25d163e > > Diff: http://git.reviewboard.kde.org/r/103281/diff/diff > > > Testing > ------- > > Successfully added a yahoo! account and connected. > > > Thanks, > > Martin Klapetek > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
