> On Nov. 28, 2011, 5:04 p.m., David Edmundson wrote: > > Discussing alternatives, you could also have just done: > > > > [ ]@yahoo.com > > > > and simply placed a label to the right on the text field. It's not a scary > > warning and is less confusing than changing people's inputs (IMHO)
Also possible. Though it changes people input only to what they have to enter anyway. The fact that it changes also displayname is another thing (and should be finally solved as well). - Martin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103281/#review8572 ----------------------------------------------------------- On Nov. 28, 2011, 1:01 p.m., Martin Klapetek wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/103281/ > ----------------------------------------------------------- > > (Updated Nov. 28, 2011, 1:01 p.m.) > > > Review request for Telepathy. > > > Description > ------- > > Haze requires yahoo! account to be without the @yahoo.com part. This patch > removes that part if user adds it. It's imho better to do this than to put a > big scary WARNING! above the line edit. Our software appears smart. > > > This addresses bug 287190. > http://bugs.kde.org/show_bug.cgi?id=287190 > > > Diffs > ----- > > plugins/haze/yahoo-main-options-widget.h 592e582 > plugins/haze/yahoo-main-options-widget.cpp 25d163e > > Diff: http://git.reviewboard.kde.org/r/103281/diff/diff > > > Testing > ------- > > Successfully added a yahoo! account and connected. > > > Thanks, > > Martin Klapetek > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
