----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104348/#review11645 -----------------------------------------------------------
lib/chat-widget.h <http://git.reviewboard.kde.org/r/104348/#comment9233> enums normally have an uppercase first letter. (also we could just use the Tp::TextChannel::ChatState enum, rather than make our own. Might be better long term) lib/chat-widget.cpp <http://git.reviewboard.kde.org/r/104348/#comment9231> This is uninitialised! Very bad! I'd be very surprised if you don't see a GCC warning about this too. lib/chat-widget.cpp <http://git.reviewboard.kde.org/r/104348/#comment9232> hmm, I don't understand why active and paused and composed are different. Can you explain them to me now? lib/chat-widget.cpp <http://git.reviewboard.kde.org/r/104348/#comment9229> This section isn't right. If we have 3 users, and one is typing and one entered text. It's better to say "typing" (the most active). This code will set it to whatever the arbitrary last one is doing. lib/chat-widget.cpp <http://git.reviewboard.kde.org/r/104348/#comment9230> Why do we turn our lovely enum into bools? - David Edmundson On March 19, 2012, 6:54 p.m., Rohan Garg wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/104348/ > ----------------------------------------------------------- > > (Updated March 19, 2012, 6:54 p.m.) > > > Review request for Telepathy. > > > Description > ------- > > Works exactly like GTalk now, when there is no message, only the user name is > displayed, if the user is typing a message, "Typing ... John Doe" is > displayed, if the user entered some text but did not hit enter "John Doe has > entered text" is displayed. > > > This addresses bug 289861. > http://bugs.kde.org/show_bug.cgi?id=289861 > > > Diffs > ----- > > app/chat-window.h 4afa8a1 > app/chat-window.cpp 5a803e6 > lib/chat-widget.h fda3106 > lib/chat-widget.cpp 907dc34 > > Diff: http://git.reviewboard.kde.org/r/104348/diff/ > > > Testing > ------- > > See attached screenshot > > > Screenshots > ----------- > > > http://git.reviewboard.kde.org/r/104348/s/480/ > > > Thanks, > > Rohan Garg > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
