> On March 20, 2012, 2:47 p.m., David Edmundson wrote: > > app/chat-window.cpp, line 273 > > <http://git.reviewboard.kde.org/r/104348/diff/2/?file=53910#file53910line273> > > > > so when the tab changes, you set it to "composing" ??? > > Rohan Garg wrote: > Wibble, I should set that to Active.
No. you should set it to what that tab is currently up to (like the old code did). - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104348/#review11653 ----------------------------------------------------------- On March 20, 2012, 2:43 p.m., Rohan Garg wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/104348/ > ----------------------------------------------------------- > > (Updated March 20, 2012, 2:43 p.m.) > > > Review request for Telepathy. > > > Description > ------- > > Works exactly like GTalk now, when there is no message, only the user name is > displayed, if the user is typing a message, "Typing ... John Doe" is > displayed, if the user entered some text but did not hit enter "John Doe has > entered text" is displayed. > > > This addresses bug 289861. > http://bugs.kde.org/show_bug.cgi?id=289861 > > > Diffs > ----- > > app/chat-window.h 4afa8a1 > app/chat-window.cpp 5a803e6 > lib/chat-widget.h fda3106 > lib/chat-widget.cpp 907dc34 > > Diff: http://git.reviewboard.kde.org/r/104348/diff/ > > > Testing > ------- > > See attached screenshot > > PS: It would be awesome if someone could test this in group chat. > > > Screenshots > ----------- > > test_screenshot > http://git.reviewboard.kde.org/r/104348/s/481/ > > > Thanks, > > Rohan Garg > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
