> On May 1, 2012, 2:39 p.m., David Edmundson wrote: > > filters/emoticons/emoticon-filter.h, line 35 > > <http://git.reviewboard.kde.org/r/104803/diff/1/?file=59836#file59836line35> > > > > You don't /need/ to use d-pointers in the filters. > > > > If you prefer to use them, go ahead - but you don't need to maintain > > binary compatibility as it's not a library people will link against. > > Lasath Fernando wrote: > It's actually a habit now - so I'm probably going to keep them there or > else it'll feel weird to me :S
I guess you already know that but if you ever need to derive a class with d-pointer and you'll create another d-pointer, you might want to derive the d-pointers as well and use the Q_ macros. Good read on this is here http://qt-project.org/wiki/Dpointer#2075f5e6067da80eed20dcf9f7ac6b52 and here http://zchydem.enume.net/2010/01/19/qt-howto-private-classes-and-d-pointers/ - Martin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104803/#review13201 ----------------------------------------------------------- On May 3, 2012, 12:02 p.m., Lasath Fernando wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/104803/ > ----------------------------------------------------------- > > (Updated May 3, 2012, 12:02 p.m.) > > > Review request for Telepathy and David Edmundson. > > > Description > ------- > > I'm starting do make some headway on my project (despite being swamped by Uni > work at the moment), so I thought I may as well review what I've done so far. > > Firstly, I gave MessageProcessor a KPluginLoader. I then cleaned it up, > removed unneeded #includes, gave AbstractMessageFilter a camel case header > etc. > > Before I started porting the three existing filters to be KPlugins, I decided > I should write unit tests for them. I'm not really sure on what the > conventions are for tests because, well I haven't seen any on this project. > So I made a few QTests and stuck them in a directory called tests. > > I've ported EscapeFilter and EmoticonFilter. I just wrote tests for > UrlFilter, but haven't got to port it yet. > > I also started documenting my work, in the hope that it'll make things easier > to maintain. Currently, the Message class is more or less documented. > If at all possible, I'd like someone who isn't familiar with how these work > internally to read it and tell me if that documentation is clear. > > > Diffs > ----- > > CMakeLists.txt e5dc102 > filters/CMakeLists.txt PRE-CREATION > filters/emoticons/CMakeLists.txt PRE-CREATION > filters/emoticons/emoticon-filter.h PRE-CREATION > filters/emoticons/emoticon-filter.cpp PRE-CREATION > filters/emoticons/ktptextui_message_filter_emoticons.desktop PRE-CREATION > filters/escape/CMakeLists.txt PRE-CREATION > filters/escape/escape-filter.h PRE-CREATION > filters/escape/escape-filter.cpp PRE-CREATION > filters/escape/ktptextui_message_filter_escape.desktop PRE-CREATION > lib/CMakeLists.txt e94a432 > lib/KTp/AbstractMessageFilter PRE-CREATION > lib/abstract-message-filter.h PRE-CREATION > lib/abstract-message-filter.cpp PRE-CREATION > lib/emoticon-filter.cpp 0e37aab > lib/escape-filter.cpp c366410 > lib/filters.h 6059ea2 > lib/ktptxtui_message_filter.desktop PRE-CREATION > lib/message-processor.h d6228b5 > lib/message-processor.cpp a9b409e > lib/message.h c9d4340 > lib/message.cpp ae947d2 > tests/CMakeLists.txt PRE-CREATION > tests/message-processor-basic-tests.h PRE-CREATION > tests/message-processor-basic-tests.cpp PRE-CREATION > tests/sync-processor.h PRE-CREATION > tests/sync-processor.cpp PRE-CREATION > > Diff: http://git.reviewboard.kde.org/r/104803/diff/ > > > Testing > ------- > > THERE ARE UNIT TESTS!! :D > > > Thanks, > > Lasath Fernando > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
