> On May 1, 2012, 2:57 p.m., Daniele Elmo Domenichelli wrote: > > filters/emoticons/ktptextui_message_filter_emoticons.desktop, line 11 > > <http://git.reviewboard.kde.org/r/104803/diff/1/?file=59838#file59838line11> > > > > Why 0.3?
To keep up with KTp. I'll ask on mailing list for what to do about this. > On May 1, 2012, 2:57 p.m., Daniele Elmo Domenichelli wrote: > > lib/abstract-message-filter.h, line 25 > > <http://git.reviewboard.kde.org/r/104803/diff/1/?file=59845#file59845line25> > > > > Reminder for later: AbstractMessageFilter should have a translatable > > description if we want an UI to enable and disable plugins.... noted. On May 1, 2012, 2:57 p.m., Lasath Fernando wrote: > > I didn't have a deep look at your code, but I think that the tests could be > > failing later if the user disables some of the plugins... True. I was considering moving them to each individual plugin, but I realized I kind of wanted these to tell me if any plugins fail to load. I guess I'll have to find some way of forcing all plugins to enable when tests are running. - Lasath ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104803/#review13208 ----------------------------------------------------------- On May 3, 2012, 12:02 p.m., Lasath Fernando wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/104803/ > ----------------------------------------------------------- > > (Updated May 3, 2012, 12:02 p.m.) > > > Review request for Telepathy and David Edmundson. > > > Description > ------- > > I'm starting do make some headway on my project (despite being swamped by Uni > work at the moment), so I thought I may as well review what I've done so far. > > Firstly, I gave MessageProcessor a KPluginLoader. I then cleaned it up, > removed unneeded #includes, gave AbstractMessageFilter a camel case header > etc. > > Before I started porting the three existing filters to be KPlugins, I decided > I should write unit tests for them. I'm not really sure on what the > conventions are for tests because, well I haven't seen any on this project. > So I made a few QTests and stuck them in a directory called tests. > > I've ported EscapeFilter and EmoticonFilter. I just wrote tests for > UrlFilter, but haven't got to port it yet. > > I also started documenting my work, in the hope that it'll make things easier > to maintain. Currently, the Message class is more or less documented. > If at all possible, I'd like someone who isn't familiar with how these work > internally to read it and tell me if that documentation is clear. > > > Diffs > ----- > > CMakeLists.txt e5dc102 > filters/CMakeLists.txt PRE-CREATION > filters/emoticons/CMakeLists.txt PRE-CREATION > filters/emoticons/emoticon-filter.h PRE-CREATION > filters/emoticons/emoticon-filter.cpp PRE-CREATION > filters/emoticons/ktptextui_message_filter_emoticons.desktop PRE-CREATION > filters/escape/CMakeLists.txt PRE-CREATION > filters/escape/escape-filter.h PRE-CREATION > filters/escape/escape-filter.cpp PRE-CREATION > filters/escape/ktptextui_message_filter_escape.desktop PRE-CREATION > lib/CMakeLists.txt e94a432 > lib/KTp/AbstractMessageFilter PRE-CREATION > lib/abstract-message-filter.h PRE-CREATION > lib/abstract-message-filter.cpp PRE-CREATION > lib/emoticon-filter.cpp 0e37aab > lib/escape-filter.cpp c366410 > lib/filters.h 6059ea2 > lib/ktptxtui_message_filter.desktop PRE-CREATION > lib/message-processor.h d6228b5 > lib/message-processor.cpp a9b409e > lib/message.h c9d4340 > lib/message.cpp ae947d2 > tests/CMakeLists.txt PRE-CREATION > tests/message-processor-basic-tests.h PRE-CREATION > tests/message-processor-basic-tests.cpp PRE-CREATION > tests/sync-processor.h PRE-CREATION > tests/sync-processor.cpp PRE-CREATION > > Diff: http://git.reviewboard.kde.org/r/104803/diff/ > > > Testing > ------- > > THERE ARE UNIT TESTS!! :D > > > Thanks, > > Lasath Fernando > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
