> On Nov. 20, 2012, 6:44 a.m., David Edmundson wrote: > > Screenshot: New group header > > <http://git.reviewboard.kde.org> > > > > Completely disagree with changing the orientation of this arrow. > > > > It's against all other treeviews (that I can see) > > Martin Klapetek wrote: > Because all other treeviews have the arrow on the left. The arrow always > points towards the "parent" item or the expanded content. Which is what it > does here.
Load up Amarok look at the top header that says "Local Collection" > On Nov. 20, 2012, 6:44 a.m., David Edmundson wrote: > > abstract-contact-delegate.cpp, line 164 > > <http://git.reviewboard.kde.org/r/106763/diff/1/?file=88844#file88844line164> > > > > Why do we set this halfway through painting? > > Martin Klapetek wrote: > This is when you want straight 1px line - you need to turn AA off (see > couple lines above), otherwise the line is AA'd and it's no longer 1px line > but 4px blurred garbage. After that line is painted, we turn AA back on. oh, that's really interesting. Copy and paste what you just said as a comment in the code :) - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106763/#review20066 ----------------------------------------------------------- On Oct. 8, 2012, 12:32 p.m., Martin Klapetek wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/106763/ > ----------------------------------------------------------- > > (Updated Oct. 8, 2012, 12:32 p.m.) > > > Review request for Telepathy. > > > Description > ------- > > I made several improvements to the group header in contact list: > > 1) Moved the expand sign to the right > 2) Removed the tiny line > 3) Made the account/group icon slightly bigger (has the same size as the > avatar in normal mode; might need adjusting) > 4) Aligned both the icon and the font with the contacts > 5) Used background color from palette disabled:highlight and lighter by > factor of 10 > > This is more a visual review request than a code, I tried with several > default KDE color schemes and I think it looks good in all of them, see the > screenshot below. Let me know what you think (and if possible try using the > patch for a while yourself and see how it fits). > > > Diffs > ----- > > abstract-contact-delegate.cpp f5f2a05 > > Diff: http://git.reviewboard.kde.org/r/106763/diff/ > > > Testing > ------- > > > Screenshots > ----------- > > New group header > http://git.reviewboard.kde.org/r/106763/s/757/ > > > Thanks, > > Martin Klapetek > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
