----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106763/#review22260 -----------------------------------------------------------
I dislike the idea to apply grouping by an icon or symbol, because the items couldn't be easily considered as in- or out-group. If you run a picture search for "accordion widget" you will find most widgets with +/- solutions (as Björn Balazs recommends), some with triangle up/down and a few with down/left (pinned at left side). I guess the right side is preserved for properties and therefore seldom used for such "high frequency functions". Normal treeview have indents, as Lasath Fernando recommends. Addionally you may add space, bevel, splitter or the like between groups (was it the "tiny line"?). And last but not least group headers should be designed different to normal entries beacause they haven't same functionality. - Heiko Tietze On Nov. 20, 2012, 10:40 a.m., Martin Klapetek wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/106763/ > ----------------------------------------------------------- > > (Updated Nov. 20, 2012, 10:40 a.m.) > > > Review request for Telepathy and KDE Usability. > > > Description > ------- > > I made several improvements to the group header in contact list: > > 1) Moved the expand sign to the right > 2) Removed the tiny line > 3) Made the account/group icon slightly bigger (has the same size as the > avatar in normal mode; might need adjusting) > 4) Aligned both the icon and the font with the contacts > 5) Used background color from palette disabled:highlight and lighter by > factor of 10 > > This is more a visual review request than a code, I tried with several > default KDE color schemes and I think it looks good in all of them, see the > screenshot below. Let me know what you think (and if possible try using the > patch for a while yourself and see how it fits). > > > Diffs > ----- > > abstract-contact-delegate.cpp f5f2a05 > > Diff: http://git.reviewboard.kde.org/r/106763/diff/ > > > Testing > ------- > > > Screenshots > ----------- > > New group header > http://git.reviewboard.kde.org/r/106763/s/757/ > > > Thanks, > > Martin Klapetek > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
