----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107811/#review23718 -----------------------------------------------------------
Screenshot please :) I'm concerned about the risk of duplicate code between the contact-list-applet and here. We're struggling to finish even one, let alone two. You've reminded me to get things sorted on the contacts-list-applet though. I'll spend some time over Christmas on it, and lets talk about making it a component or something so you can share it. I think a discussion on the mailing list summing up all your goals on the chat-applet would be worthwhile. I like this idea of pinning contacts. Better to discuss the other things before we write code. plasmoid/org.kde.ktp-chatplasmoid/contents/ui/ContactList.qml <http://git.reviewboard.kde.org/r/107811/#comment18160> Our AccountsFilterModel is designed so it can be used from QML. It's more advanced, powerful and faster than the silly plasma one. - David Edmundson On Dec. 19, 2012, 3:10 a.m., Aleix Pol Gonzalez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/107811/ > ----------------------------------------------------------- > > (Updated Dec. 19, 2012, 3:10 a.m.) > > > Review request for Telepathy and David Edmundson. > > > Description > ------- > > I've wanted to use this plasmoid for longtime, I fear that the reason why I'm > not using it yet is because I can't start chats from there. The plan is that > this will improve the situation, to some extent. > > The important part about the patch is that the root element is refactored > into a grid that can have different elements. Now I added a button with a > contactlist that probably should go, but eventually i'd like to have > non-conversation buttons so that one can pin contacts. > > > Diffs > ----- > > plasmoid/declarative-plugin/conversations-model.h f9dc047 > plasmoid/declarative-plugin/conversations-model.cpp faaa60b > plasmoid/org.kde.ktp-chatplasmoid/contents/ui/ContactList.qml PRE-CREATION > plasmoid/org.kde.ktp-chatplasmoid/contents/ui/ConversationDelegate.qml > 8a8d851 > > plasmoid/org.kde.ktp-chatplasmoid/contents/ui/ConversationDelegateButton.qml > PRE-CREATION > plasmoid/org.kde.ktp-chatplasmoid/contents/ui/main.qml feb766b > > Diff: http://git.reviewboard.kde.org/r/107811/diff/ > > > Testing > ------- > > Very little, mostly sending this review for starting a discussion on where > we'd like to go with this plasmoid. > > > Thanks, > > Aleix Pol Gonzalez > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
