----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107811/ -----------------------------------------------------------
(Updated Jan. 8, 2013, 2:30 a.m.) Review request for Telepathy and David Edmundson. Changes ------- Removed the contact list button, now we can only start conversations by clicking on a pinned contact. Now we save the state by using plasmoid.writeConfig, so the configuration is local to the plasmoid. Specially important because it lets us have different instances and makes it activity aware for free. Some other small things fixed as well The only missing thing is that when you start a chat from a pinned button, the chat dialog is not automatically opened. I have no idea of how we can pass such information with ensureTextChat. Another possibility is to check if it's the plasmoid who is requesting the chat. If somebody tells me how to implement it I'll do it. Description ------- I've wanted to use this plasmoid for longtime, I fear that the reason why I'm not using it yet is because I can't start chats from there. The plan is that this will improve the situation, to some extent. The important part about the patch is that the root element is refactored into a grid that can have different elements. Now I added a button with a contactlist that probably should go, but eventually i'd like to have non-conversation buttons so that one can pin contacts. Diffs (updated) ----- plasmoid/declarative-plugin/CMakeLists.txt 48ba8a7 plasmoid/declarative-plugin/contactpin.h PRE-CREATION plasmoid/declarative-plugin/contactpin.cpp PRE-CREATION plasmoid/declarative-plugin/conversation-target.h cd45f2d plasmoid/declarative-plugin/conversation-target.cpp f9c285d plasmoid/declarative-plugin/conversation.h 6eeab86 plasmoid/declarative-plugin/conversation.cpp 152d940 plasmoid/declarative-plugin/conversations-model.h f9dc047 plasmoid/declarative-plugin/conversations-model.cpp faaa60b plasmoid/declarative-plugin/ktp-metatypes.h PRE-CREATION plasmoid/declarative-plugin/pinnedcontactsmodel.h PRE-CREATION plasmoid/declarative-plugin/pinnedcontactsmodel.cpp PRE-CREATION plasmoid/declarative-plugin/qml-plugins.cpp 23a4291 plasmoid/declarative-plugin/telepathy-text-observer.h 241febb plasmoid/declarative-plugin/telepathy-text-observer.cpp 98dfced plasmoid/org.kde.ktp-chatplasmoid/contents/config/main.xml PRE-CREATION plasmoid/org.kde.ktp-chatplasmoid/contents/ui/ChatWidget.qml ea68f41 plasmoid/org.kde.ktp-chatplasmoid/contents/ui/ContactList.qml PRE-CREATION plasmoid/org.kde.ktp-chatplasmoid/contents/ui/ConversationDelegate.qml 8a8d851 plasmoid/org.kde.ktp-chatplasmoid/contents/ui/ConversationDelegateButton.qml PRE-CREATION plasmoid/org.kde.ktp-chatplasmoid/contents/ui/main.qml feb766b Diff: http://git.reviewboard.kde.org/r/107811/diff/ Testing ------- Very little, mostly sending this review for starting a discussion on where we'd like to go with this plasmoid. Screenshots ----------- i am pinned http://git.reviewboard.kde.org/r/107811/s/952/ pin me http://git.reviewboard.kde.org/r/107811/s/953/ Thanks, Aleix Pol Gonzalez
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
