> On Jan. 9, 2013, 5:13 p.m., David Edmundson wrote: > > plasmoid/declarative-plugin/messages-model.cpp, line 52 > > <http://git.reviewboard.kde.org/r/107811/diff/5/?file=106093#file106093line52> > > > > Can you talk me through this whole "startOpened" thing? > > > > So there's going to be an option in the UI as to whether all chats > > start opened or not, but it only has any impact for chats started via the > > chat plasmoid? > > Aleix Pol Gonzalez wrote: > No, that's not for GUI configurability, it's only for telling the > front-end code that this new conversation that just appeared has just started > needs to be opened instantly. Otherwise we only get a button with the > conversation on but not showing. > We say that by passing a specific hint ourselves. > > David Edmundson wrote: > So let me confirm the behavior we're trying to get: > - if it's started from this applet it opens instantly > - it it's started from elsewhere (such as the contact list, contact > plasmoid, or the other contact started the chat) you get the contact icon, > but it doesn't pop out straight away > > ?
Yes. The thing is that in both cases the conversation channel is opened, the difference is that if you click a pinned is to start saying things right away but when somebody talks to you we need the user to stop doing whatever he's doing before showing the conversation. - Aleix ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107811/#review25082 ----------------------------------------------------------- On Jan. 10, 2013, 1:41 a.m., Aleix Pol Gonzalez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/107811/ > ----------------------------------------------------------- > > (Updated Jan. 10, 2013, 1:41 a.m.) > > > Review request for Telepathy and David Edmundson. > > > Description > ------- > > I've wanted to use this plasmoid for longtime, I fear that the reason why I'm > not using it yet is because I can't start chats from there. The plan is that > this will improve the situation, to some extent. > > The important part about the patch is that the root element is refactored > into a grid that can have different elements. Now I added a button with a > contactlist that probably should go, but eventually i'd like to have > non-conversation buttons so that one can pin contacts. > > > Diffs > ----- > > plasmoid/declarative-plugin/CMakeLists.txt 48ba8a7 > plasmoid/declarative-plugin/contact-pin.h PRE-CREATION > plasmoid/declarative-plugin/contact-pin.cpp PRE-CREATION > plasmoid/declarative-plugin/conversation-target.h cd45f2d > plasmoid/declarative-plugin/conversation-target.cpp f9c285d > plasmoid/declarative-plugin/conversation.h 6eeab86 > plasmoid/declarative-plugin/conversation.cpp 152d940 > plasmoid/declarative-plugin/conversations-model.h f9dc047 > plasmoid/declarative-plugin/conversations-model.cpp faaa60b > plasmoid/declarative-plugin/ktp-metatypes.h PRE-CREATION > plasmoid/declarative-plugin/messages-model.h 233bbfb > plasmoid/declarative-plugin/messages-model.cpp a33b3c4 > plasmoid/declarative-plugin/pinned-contacts-model.h PRE-CREATION > plasmoid/declarative-plugin/pinned-contacts-model.cpp PRE-CREATION > plasmoid/declarative-plugin/qml-plugins.cpp 23a4291 > plasmoid/declarative-plugin/telepathy-text-observer.h 241febb > plasmoid/declarative-plugin/telepathy-text-observer.cpp 98dfced > plasmoid/org.kde.ktp-chatplasmoid/contents/config/main.xml PRE-CREATION > plasmoid/org.kde.ktp-chatplasmoid/contents/ui/ChatWidget.qml ea68f41 > plasmoid/org.kde.ktp-chatplasmoid/contents/ui/ContactList.qml PRE-CREATION > plasmoid/org.kde.ktp-chatplasmoid/contents/ui/ConversationDelegate.qml > 8a8d851 > > plasmoid/org.kde.ktp-chatplasmoid/contents/ui/ConversationDelegateButton.qml > PRE-CREATION > plasmoid/org.kde.ktp-chatplasmoid/contents/ui/main.qml feb766b > > Diff: http://git.reviewboard.kde.org/r/107811/diff/ > > > Testing > ------- > > Very little, mostly sending this review for starting a discussion on where > we'd like to go with this plasmoid. > > > Screenshots > ----------- > > i am pinned > http://git.reviewboard.kde.org/r/107811/s/952/ > pin me > http://git.reviewboard.kde.org/r/107811/s/953/ > > > Thanks, > > Aleix Pol Gonzalez > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
