> On Feb. 17, 2013, 12:24 p.m., Heiko Tietze wrote: > > Pretty nice. Arrow orientation is okay but I would remove group icons. As > > far as I see they don't add information and, if group icons are omitted, > > white space makes grouping more effective. > > Martin Klapetek wrote: > I agree with the group icons, they are useless. There are however account > icons (when in accounts grouping mode), which you can choose yourself. So > leave them when in accounts mode but remove (useless) group icons?
Uh, option all-around ;-). I'm fine with your solution. Ship it! - Heiko ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106763/#review27573 ----------------------------------------------------------- On Feb. 17, 2013, 12:35 p.m., Martin Klapetek wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/106763/ > ----------------------------------------------------------- > > (Updated Feb. 17, 2013, 12:35 p.m.) > > > Review request for Telepathy and KDE Usability. > > > Description > ------- > > I made several improvements to the group header in contact list: > > 1) Moved the expand sign to the right > 2) Removed the tiny line > 3) Made the account/group icon slightly bigger (has the same size as the > avatar in normal mode; might need adjusting) > 4) Aligned both the icon and the font with the contacts > 5) Used background color from palette disabled:highlight and lighter by > factor of 10 > > This is more a visual review request than a code, I tried with several > default KDE color schemes and I think it looks good in all of them, see the > screenshot below. Let me know what you think (and if possible try using the > patch for a while yourself and see how it fits). > > > Diffs > ----- > > abstract-contact-delegate.cpp 836913f > > Diff: http://git.reviewboard.kde.org/r/106763/diff/ > > > Testing > ------- > > > File Attachments > ---------------- > > Take Two > http://git.reviewboard.kde.org/media/uploaded/files/2013/02/17/headers_2.png > accounts mode > http://git.reviewboard.kde.org/media/uploaded/files/2013/02/17/headers_3.png > > > Screenshots > ----------- > > New group header > http://git.reviewboard.kde.org/r/106763/s/757/ > > > Thanks, > > Martin Klapetek > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
