> On March 13, 2013, 1:43 p.m., David Edmundson wrote: > > KTp/contact.cpp, line 114 > > <http://git.reviewboard.kde.org/r/109460/diff/1/?file=119583#file119583line114> > > > > No mixing the word "token" and filePaths. > > > > Tbh, storing the token kinda makes more sense. > > > > Martin Klapetek wrote: > It would, but you don't know the rest of the path, so you can't retrieve > the file using just the token.
Would be a case of copying ContactManager::Private::buildAvatarFileName() - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109460/#review29125 ----------------------------------------------------------- On March 13, 2013, 12:49 p.m., Martin Klapetek wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/109460/ > ----------------------------------------------------------- > > (Updated March 13, 2013, 12:49 p.m.) > > > Review request for Telepathy. > > > Description > ------- > > Adds loading the avatar in KTp::Contact::avatar(). The config part might need > adjusting. Also keyCache() is unreliable because we can't rely on avatarToken > being present in the features, so I changed it to contact id instead. > > > Diffs > ----- > > KTp/contact.cpp 26c8847 > > Diff: http://git.reviewboard.kde.org/r/109460/diff/ > > > Testing > ------- > > Works. > > > Thanks, > > Martin Klapetek > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
