> On March 14, 2013, 11:40 a.m., David Edmundson wrote: > > KTp/contact.cpp, line 171 > > <http://git.reviewboard.kde.org/r/109460/diff/2/?file=119610#file119610line171> > > > > QString::fromLatin1 > > > > not QString(QLatin1String()) > > > > everywhere in this method. > > Martin Klapetek wrote: > Copied from Collabora masters... :P
That doesn't make it ok! - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109460/#review29195 ----------------------------------------------------------- On March 13, 2013, 4:24 p.m., Martin Klapetek wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/109460/ > ----------------------------------------------------------- > > (Updated March 13, 2013, 4:24 p.m.) > > > Review request for Telepathy. > > > Description > ------- > > Adds loading the avatar in KTp::Contact::avatar(). The config part might need > adjusting. Also keyCache() is unreliable because we can't rely on avatarToken > being present in the features, so I changed it to contact id instead. > > > Diffs > ----- > > KTp/contact.h da4f895 > KTp/contact.cpp 26c8847 > > Diff: http://git.reviewboard.kde.org/r/109460/diff/ > > > Testing > ------- > > Works. > > > Thanks, > > Martin Klapetek > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
