> On March 15, 2013, 1:19 a.m., David Edmundson wrote: > > That just means some numpty isn't including FeatureAvatarToken > > Alin M Elena wrote: > I think Martin added it.. simply for offline contacts comes as empty > string. > > Alin > > Alin M Elena wrote: > ok... I see a problem... but it may be only me... > > if an avatar changes his avatar... his token is changing (his key in the > rc changes too.) > i suspect the id does not change... so we pull for offline an outdated > image from cache. > > maybe the cacheKey shall be build based on the string we have in hash. > > Alin
For the record, I added it to kded, that does not mean it's added to everywhere else, which it might not. - Martin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109490/#review29247 ----------------------------------------------------------- On March 15, 2013, 9:06 a.m., Alin M Elena wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/109490/ > ----------------------------------------------------------- > > (Updated March 15, 2013, 9:06 a.m.) > > > Review request for Telepathy, David Edmundson and Martin Klapetek. > > > Description > ------- > > using avatarToken for keyCache ends up with "-offline" for all grayed avatars > as cache entries.. which is obviously wrong... I used id() instead... > Martin's original idea. > > > This addresses bug 316743. > http://bugs.kde.org/show_bug.cgi?id=316743 > > > Diffs > ----- > > KTp/contact.h 32af16b > KTp/contact.cpp 84ae642 > > Diff: http://git.reviewboard.kde.org/r/109490/diff/ > > > Testing > ------- > > build and now offline avatars are correctly grayed. > > > Thanks, > > Alin M Elena > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
