> On March 15, 2013, 10:44 a.m., Martin Klapetek wrote:
> > KTp/contact.cpp, line 111
> > <http://git.reviewboard.kde.org/r/109490/diff/6/?file=119907#file119907line111>
> >
> >     Why?

because I hate using implicitly initialised variables... 


- Alin M


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109490/#review29269
-----------------------------------------------------------


On March 15, 2013, 10:42 a.m., Alin M Elena wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109490/
> -----------------------------------------------------------
> 
> (Updated March 15, 2013, 10:42 a.m.)
> 
> 
> Review request for Telepathy, David Edmundson and Martin Klapetek.
> 
> 
> Description
> -------
> 
> using avatarToken for keyCache ends up with "-offline" for all grayed avatars 
> as cache entries.. which is obviously wrong... I used id() instead... 
> Martin's original idea.
> 
> 
> This addresses bug 316743.
>     http://bugs.kde.org/show_bug.cgi?id=316743
> 
> 
> Diffs
> -----
> 
>   KTp/contact.h 32af16b 
>   KTp/contact.cpp 84ae642 
> 
> Diff: http://git.reviewboard.kde.org/r/109490/diff/
> 
> 
> Testing
> -------
> 
> build and now offline avatars are correctly grayed.
> 
> 
> Thanks,
> 
> Alin M Elena
> 
>

_______________________________________________
KDE-Telepathy mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/kde-telepathy

Reply via email to