> On May 1, 2013, 2:01 p.m., David Edmundson wrote: > > filters/urlexpansion/urlexpansion-filter.cpp, line 54 > > <http://git.reviewboard.kde.org/r/110255/diff/1/?file=141590#file141590line54> > > > > I'm a bit worried about this. > > If we get a message and longurl.org is offline we now take 30 seconds > > (till timeout) whilst we are completely blocking the UI. > > > > I suggest we make this async, and if the user gets any short links > > before this finishes - tough luck to them. > > > > unless anyone can think of something better that isn't over-complicated?
or we could cache this locally. Either on first run or we can just ship this file http://api.longurl.org/v2/services?format=json in our release tarball. I could add it to the packaging scripts to download and save it. - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110255/#review31835 ----------------------------------------------------------- On May 1, 2013, 12:08 p.m., Anant Kamath wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/110255/ > ----------------------------------------------------------- > > (Updated May 1, 2013, 12:08 p.m.) > > > Review request for Telepathy, David Edmundson and Daniele E. Domenichelli. > > > Description > ------- > > The plugin checks for available services from longurl.org upon loading. > > Filtering is done in the client via javascript. > > > This addresses bug 310512. > http://bugs.kde.org/show_bug.cgi?id=310512 > > > Diffs > ----- > > filters/CMakeLists.txt c66e773 > filters/urlexpansion/CMakeLists.txt PRE-CREATION > filters/urlexpansion/ktptextui_message_filter_urlexpansion.desktop.cmake > PRE-CREATION > filters/urlexpansion/longurl.js PRE-CREATION > filters/urlexpansion/urlexpansion-filter.h PRE-CREATION > filters/urlexpansion/urlexpansion-filter.cpp PRE-CREATION > > Diff: http://git.reviewboard.kde.org/r/110255/diff/ > > > Testing > ------- > > Tested. Check screenshots. > > > File Attachments > ---------------- > > > http://git.reviewboard.kde.org/media/uploaded/files/2013/05/01/url1.png > > > Thanks, > > Anant Kamath > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
