> On May 1, 2013, 10:37 p.m., David Edmundson wrote: > > filters/urlexpansion/urlexpansion-filter.cpp, line 82 > > <http://git.reviewboard.kde.org/r/110255/diff/2/?file=141672#file141672line82> > > > > QLatin1Char('/')
QString and QLatin1Char can't be compared. - Anant ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110255/#review31859 ----------------------------------------------------------- On May 1, 2013, 9:31 p.m., Anant Kamath wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/110255/ > ----------------------------------------------------------- > > (Updated May 1, 2013, 9:31 p.m.) > > > Review request for Telepathy, David Edmundson and Daniele E. Domenichelli. > > > Description > ------- > > The plugin checks for available services from longurl.org upon loading. > > Filtering is done in the client via javascript. > > > This addresses bug 310512. > http://bugs.kde.org/show_bug.cgi?id=310512 > > > Diffs > ----- > > filters/CMakeLists.txt c66e773 > filters/urlexpansion/CMakeLists.txt PRE-CREATION > filters/urlexpansion/ktptextui_message_filter_urlexpansion.desktop.cmake > PRE-CREATION > filters/urlexpansion/longurl.js PRE-CREATION > filters/urlexpansion/longurlServices.json PRE-CREATION > filters/urlexpansion/urlexpansion-filter.h PRE-CREATION > filters/urlexpansion/urlexpansion-filter.cpp PRE-CREATION > > Diff: http://git.reviewboard.kde.org/r/110255/diff/ > > > Testing > ------- > > Tested. Check screenshots. > > > File Attachments > ---------------- > > > http://git.reviewboard.kde.org/media/uploaded/files/2013/05/01/url1.png > > > Thanks, > > Anant Kamath > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
