> On July 5, 2013, 11:15 a.m., David Edmundson wrote: > > main-widget.cpp, line 586 > > <http://git.reviewboard.kde.org/r/111387/diff/1/?file=168084#file168084line586> > > > > I want this terminology consistent throughout libkpeople usage. > > > > In the Person app we use "merge". > > > > I like "link" too.. but I want it the same.
Ok, I'll change the viewer to "Link" too. > On July 5, 2013, 11:15 a.m., David Edmundson wrote: > > main-widget.cpp, line 732 > > <http://git.reviewboard.kde.org/r/111387/diff/1/?file=168084#file168084line732> > > > > This needs #ifdef > On July 5, 2013, 11:15 a.m., David Edmundson wrote: > > main-widget.cpp, line 698 > > <http://git.reviewboard.kde.org/r/111387/diff/1/?file=168084#file168084line698> > > > > Why do we need to do this? > > Doesn't KPeople do it all internally? Not exactly, it just identifies what is a person and what is a contact and that's it, then Nepomuk would happily link these together, but we agreed that for example one contact cannot be linked to two persons. I wonder if this should be part of kpeople though. On the other hand contact list is a bit special case as it displays a tree of contacts and as such the user can select random stuff... - Martin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111387/#review35628 ----------------------------------------------------------- On July 4, 2013, 10:49 a.m., Martin Klapetek wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/111387/ > ----------------------------------------------------------- > > (Updated July 4, 2013, 10:49 a.m.) > > > Review request for Telepathy. > > > Description > ------- > > Adds KDualAction to merge contacts into a metacontact or unmerge > metacontacts. It still misses couple things (eg. getting the returned job and > then the uri of new created person), but it's quite complex and I'd like to > get early feedback on it. > > There are many combinations that the user can select, main 9 ones (0 > contacts, 1 contact, n contacts in combination with 0 persons, 1 person, n > persons) plus cases like "contact is a subcontact of selected person", > "contact is subcontact of different person" etc. > > > Diffs > ----- > > contact-list-widget.h 0ab5449 > contact-list-widget.cpp 1bdf635 > main-widget.h 8dab6e0 > main-widget.cpp b9129fa > > Diff: http://git.reviewboard.kde.org/r/111387/diff/ > > > Testing > ------- > > Selecting different contact combinations properly sets the KDualAction. > > > Thanks, > > Martin Klapetek > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
